970555 - overlay buttons only appearing for the first tab after switching between fxdesktop to fxmetro

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

When switching between fxdesktop -> fxmetro, the on screen overlay buttons will only appear for the first tab in the navigation app bar. Creating new tabs will slide in the overlay's without any issues but the tabs that have been switched over will not have the overlays. (other than the first tab)

Steps to reproduce the issue:

1) Open fxdesktop
2) Once opened, open a few websites in new tabs (three tabs should be enough)
3) Switch over to fxmetro
4) You'll notice that the first tab has the overlays correctly being displayed but the other two won't have them displayed

Current Behavior:

- Only the first tab will have the overlay buttons visible when switching between fxdesktop -> fxmetro

Expected Behavior:

- When switching into fxmetro from fxdesktop, all the tabs that are already opened should have the overlay buttons visible

Issue reproducible on the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-10-03-02-01-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-10-00-40-02-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest-beta/win32/en-US/

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

This happens when the tab has no history. When you open a tab in metro from the start page, it'll have the start page as the first item in history. That doesn't happen in desktop. 

When you can't go back we disable both overlay buttons. We can keep the new tab button and hide only the back button in this case. What do you think Yuan?

Comment 2

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

The back button and new button should always appear as a set.

Just tested on Firefox Beta, the issue doesn't seem to apply. The desired flow for this case: On-screen buttons should be visible when switched from desktop to metro. If the tab has no history, hitting back button should take the user to Start Page.

Comment 3

[Firefox Bug Husbandry Bot]

Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354