836791 - Story - Junior-style back and new tab overlay buttons

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-3-21 Junior-style back and forward navigation

Comment 1

[Asa Dotzler [:asa]]

Attachment: UC-3-21 Junior-style back and forward navigation

Comment 2

[Frank Yan (:fryn)]

I received a mockup and some design assets for this from Stephen.

Comment 3

[Frank Yan (:fryn)]

Attachment: WIP

WIP from last Wednesday.
Complete patch coming soon.

Comment 4

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Stephen, based on the mockup you posted, how would people go forward?

Since the Back button and fav icon are not connected with the URL field, the Australis conditional back button cannot be applied here.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 723619 [details] [diff] [review]
WIP

This is obsolete now that I have filed the relevant Work bugs and attached complete patches to several of them.

Comment 6

[Frank Yan (:fryn)]

The essential pieces of this have landed.
I think this is sufficient for closing this story.
We will continue to tweak and improve the interactions here as needed, but they need not keep this story open.

Comment 8

[Frank Yan (:fryn)]

I realize that the history of this story is a bit confusing.
Asa created two duplicate story bugs for this. I duped the other to this one.
I don't think the point value of this bug should be changed to zero. There were substantive work bugs (bug 859950, bug 859997, and bug 860095) and additional work not found on Bugzilla (solidifying the interaction model of the buttons) involved in the completion of this story. If anything, I'd say it ended up being at least a 5.

I took the opportunity to being in the same room as Stephen and Yuan to complete this story as part of iteration 5, so I'm marking this as iteration 5. Please let me know if this is incorrect.

Comment 9

[Marco Mucci [:MarcoM]]

Temporarily reopening for inclusion in Iteration #5.

Comment 10

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130414 Firefox/23.0 

Used the Nightly version built from http://hg.mozilla.org/mozilla-central/rev/ef802a6418f2

- back and plus buttons are displayed
- back and plus buttons functional

Issues: invoking the app bar (right click) doesn't make the buttons disappear (as specified in the user story). I think this is tracked in bug 861465.

And one question before setting this to verified: is there a way to access elements overlayed by the two buttons? (e.g www.gsp.ro). The green square is unaccessible.

Comment 11

[Marco Mucci [:MarcoM]]

See question from Virgil in Comment #10.

Comment 12

[Frank Yan (:fryn)]

(In reply to Virgil Dicu [:virgil] [QA] from comment #10)
> And one question before setting this to verified: is there a way to access
> elements overlayed by the two buttons? (e.g www.gsp.ro). The green square is
> unaccessible.

Not yet. I forgot to file a followup for it. The current plan is to enable the buttons to be moved via drag / touch. This isn't part of the story as written by Asa, so it's not needed to close this bug, but I'm definitely going to fix it ASAP.

Comment 13

[Virgil Dicu [:virgil] [QA]]

Thanks. Setting to verified considering comment 12.

Comment 14

[Kamil Jozwiak [:kjozwiak]]

Found a "Defect" when going through the following "Story". Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Attached the Defect to this Story.

Comment 15

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Story" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-10-03-11-47-mozilla-central/

- Went through the original story and ensured the buttons worked as described
- Ensured that both the "Back" and "New Tab" junior style buttons are working when opening websites from either "Top Sites", "Bookmarks" or "Recent History"
- Ensured that both the "Back" and "New Tab" junior style buttons are working when opening a new link using the right click context menu
- Ensured that you can press the "Back" junior style button several times without any issues
- Ensured that all of the above test cases also worked in "Filled View" without any issues

Quick Note:

- As per Comment 10, invoking the app bar does not hide the junior buttons as described in the original story. The issue can be found in Bug 861465

Comment 16

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130707 Firefox/25.0
Build ID: 20130707031138

WFM for iteration-9
Tested on Windows 8.1 preview using latest nightly build from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-07-03-11-38-mozilla-central/
I used same steps given in user story.
I am getting expected result.

Comment 17

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and got expected result.