970689 - [B2G][Email]File name not displayed after user downloads and views attached image file from Email App on device

Status: RESOLVED DUPLICATE of bug 1048798

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Montoya Clemmons (MClemmons)]

Attachment: EmailScreenshotNoFileName

User downloads any type of image file within the Email App, the image appears without a file name listed in the header section on device screen

Repro Steps:
1) Updated Buri to BuildID: 20140210004002
2) Send email with attachment to device 
3) Select download and view from within Email App 

Actual:
File displays with the header section as a white bar with no file name or description

Expected:
File displays with header section as a white bar with file name or description

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140210004002
Gaia: 5c8416fb1ea4a27f172ee6386ab3c19135448506
Gecko: 9c9382f433c0
Version: 28.0
Firmware Version: V1.2-device.cfg

Notes:
1. Repro frequency: (5/5, 100%)
2. Link to failed test case:
 https://moztrap.mozilla.org/manage/case/3995/
3. See attached: (screenshot, logcat)
4. When user selects same image file to send out as an attachment from within email app, the file is given a named convention. Example, tap gallery app, tap file, tap share with icon and select email button, the attachment field has a file name. As a user, I would expect similar behavior incoming as outgoing.
5. The type of device in use - Buri
6. The "Build Identifier" of the build you are using - BuildID: 20140210004002
7. Confirm the net connection is working - confirmed
8. The e-mail domain you used/are using to create the account - aol.com
9. If this is not a problem creating the account, the account type the e-mail client thinks it is using – "IMAP+SMTP".
10. A log of what was happening around the time the problem happened - Attached

Comment 1

[Montoya Clemmons (MClemmons)]

This issue reproduces on Buri 1.2 Following the STR in Comment 0 displays no named convention after file download and view.

Environmental Variables:
Device: Buri 1.2 MOZ
BuildID: 20140210004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2673f348598c
Version: 26.0
Firmware Version: v1.2-device.cfg

Comment 2

[Montoya Clemmons (MClemmons)]

This issue reproduces on Buri 1.1 Following the STR in Comment 0 displays no named convention for file downloaded and viewed.

Environmental Variables:
Device: buri 1.1 MOZ
BuildID: 20140210041201
Gaia: c5cb252e5d1aa45d14f3a2ea182e73e2271e4496
Gecko: c29d165756ab
Version: 18.0

Comment 3

[Montoya Clemmons (MClemmons)]

Attachment: EmailAppLogcat

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

The gallery app's open implementation currently expects us to pass "filename" in the activity to get the filename to show up.  We don't do this and so it chooses an empty string.  (Note: As long as don't also pass "allowSave" as truthy, we don't have to worry about passing the filename changing behaviour so that the user can produce a duplicate copy of the file.)

Another option is that since the blob we pass is actually a File, Gallery could also just pull the filename out of the File (using "blob.name").

Comment 7

[James Burke [:jrburke]]

As indicated in bug 1017598, when fixing this, we should also pass allowSave to get parity with the SMS messages app.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

The email app always saves attachments to DeviceStorage right now (although the intent is to change this in the future).  Passing allowSave and having the user save the image would result in a duplicate image or just a failure to save.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Duping forward to a bug with a patch.