971107 - Tests for snippets

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Testing, defect)

Description

[:Margaret Leibovic]

We have testHomeBanner to test the basic home banner functionality, but we should add some tests that are specific to snippets.

Setting up this test will involve quite a few things:
* Set "browser.snippets.enabled" to true (disabled by default in test profile)
* Set "browser.snippets.countryCode" to "US" (just for testing)
* Set "browser.snippets.geoLastUpdate" to now (so that we don't try updating)
* Set "browser.snippets.updateUrl" to some local test file (and create that test file)

Then we need to trigger the snippets to update, maybe we can just do that by making ""browser.snippets.updateInterval" really low, but that doesn't seem totally reliable. Perhaps we should observe a new test notification in Snippets.js.

Then to actually test things, we should open about:home and check that the snippet is shown in the home banner. We can also test that clicking on the banner will open a specific URL.

Comment 1

[:Margaret Leibovic]

For more on testing, see this wiki page:
https://wiki.mozilla.org/Mobile/Fennec/Android/Testing

Comment 2

[:Margaret Leibovic]

I finally added a test in bug 1227743!

Comment 3

[:Margaret Leibovic]

I want to land the patch in bug 1227743, but I still haven't figured out issues with the test failures on try. I'm going to reopen this bug and do that investigation here.

Comment 4

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87895419e8a0

Comment 5

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #4)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=87895419e8a0

I tried simplifying the test, but it's still timing out :(

I suppose I need to make a bunch of try runs with various things commented out.

Comment 6

[:Margaret Leibovic]

Attachment: Bug 971107 - Create test for snippetsi

Review commit: https://reviewboard.mozilla.org/r/60280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60280/

Comment 7

[:Margaret Leibovic]

I never ended up fixing this test to run properly in automation, but this patch should be useful if anyone works on snippets again.

Comment 8

[Geoff Brown [:gbrown]]

Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.