Closed
Bug 971336
Opened 12 years ago
Closed 12 years ago
Add test for bug 970276
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 30
People
(Reporter: billm, Assigned: billm)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
6.29 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8374505 -
Flags: review?(felipc)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8374505 [details] [diff] [review]
favicon-test
>diff --git a/browser/base/content/test/general/file_bug970276_popup1.html~ b/browser/base/content/test/general/file_bug970276_popup1.html~
>new file mode 100644
>--- /dev/null
>+++ b/browser/base/content/test/general/file_bug970276_popup1.html~
>@@ -0,0 +1,12 @@
>+<!DOCTYPE HTML>
>+<html>
>+<head>
>+ <title>Test file for bug 970276.</title>
>+
>+ <!--Set a favicon; that's the whole point of this file.-->
>+ <link rel="icon" href="file_bug550565_favicon.ico">
>+</head>
>+<body>
>+ Test file for bug 550565.
>+</body>
>+</html>
I don't think you meant to `hg add` the backup file.
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8374505 [details] [diff] [review]
favicon-test
Review of attachment 8374505 [details] [diff] [review]:
-----------------------------------------------------------------
There was a recent agreement to not name tests with just bug numbers anymore, but instead use a descriptive name for what it does.. so browser_subframe_favicons_not_used.js (or something like that..)
No need to rename the support files. And a reminder to remove the backup file.
Attachment #8374505 -
Flags: review?(felipc) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → wmccloskey
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•