Closed Bug 971480 Opened 10 years ago Closed 10 years ago

[System2] Instantiable CostControl

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
salva
: feedback+
Details | Review 
+++ This bug was initially created as a clone of Bug #971479 +++

We need cost_control.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
Taking.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Attached file Github pull request — 
Work in progress.
Comment on attachment 8496469 [details] [review]
Github pull request

Alive - I think it makes sense to have utility tray instantiate this file as this code is just related to the widget. What do you think?
Attachment #8496469 - Flags: review?(alive)
Comment on attachment 8496469 [details] [review]
Github pull request

flag salva for feedback if something is missing.
Attachment #8496469 - Flags: review?(alive)
Attachment #8496469 - Flags: review+
Attachment #8496469 - Flags: feedback?(salva)
Comment on attachment 8496469 [details] [review]
Github pull request

Working fine. Nice work and thank you.
Attachment #8496469 - Flags: feedback?(salva) → feedback+
Thanks guys. In master: https://github.com/mozilla-b2g/gaia/commit/23a3f5475a94442a620559fb9033e373d9926f06
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: