971512 - [System2] Instantiable LayoutManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need layout_manager.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch on bubble-tea

* Refactor LayoutManager and change variable name in which it's used by other modules.
* Also fix jshint of app_transition_controller.

Alive may you help review this patch?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8381127 [details]
patch on bubble-tea

r+ with nits

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for your help Alive! :)

landed on bubble-tea:
https://github.com/mozilla-b2g/gaia/commit/22ef3c5c16c8277e8fd216fea3604733221561f3

Comment 4

[[e-mail]]

Rex, Though we plan to merge bubble-tea to master in order.
Due to test fail occurred while cherry-pick this patch, please help create a PR, check travis is green and land it to master. Thanks.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Seems only one marionette test failed (which is not related).
I'll try merge after rebasing.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/bcdeca5898d7c3763df466390f1b06a0093e1d9a

Comment 7

[Carsten Book [:Tomcat]]

sorry had to revert this commit for test failures in gaia unit tests like https://tbpl.mozilla.org/php/getParsedLog.php?id=36793472&tree=B2g-Inbound

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Pull request for master

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master:
https://github.com/mozilla-b2g/gaia/commit/3a5628ef7bfb33a70ac106e22eef4d18866cdffe