971604 - Video: make header "month date" localizable in thumbnail mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Francesco Lodolo [:flod]]

Clone of bug 968069 (Gallery) for Video app. We need to make the header localizable.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16202

Comment 2

[Francesco Lodolo [:flod]]

Attachment: video.png

Screenshot on Keon, with test value
date-group-header = %B…%Y

Comment 3

[Francesco Lodolo [:flod]]

I'm getting an error in tests (thumbnail_date_group_test.js), which I can't really understand
ReferenceError: _ is not defined

But at the beginning of the file I also have
navigator.mozL10n = MockL10n;
MediaUtils._ = MockL10n.get;

So everything should work, as it works in video_test.js

Comment 4

[Francesco Lodolo [:flod]]

I fixed the test locally, now waiting for Travis to run online.

Not sure about the way I did it though (adding a variable declaration of _ in js/thumbnail_date_group.js).
Code works on my keon, all video tests pass, but I have no idea if this create other issues that I don't see.

Comment 5

[Punam Dahiya [:pdahiya]]

Restarted unrelated failed marionette job on travis https://travis-ci.org/mozilla-b2g/gaia/jobs/18722710

Comment 6

[Francesco Lodolo [:flod]]

Looks green
https://travis-ci.org/mozilla-b2g/gaia/builds/18722706

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 8374679 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16202

Patch looks good, r+ from me. Thanks for the fix.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: 9f36dbb491c29c414fae21dcdbda557e24eb28c3

Comment 9

[Francesco Lodolo [:flod]]

Verified on 1.4 (2014-03-02, git 46b455c9)