Closed Bug 971604 Opened 7 years ago Closed 7 years ago

Video: make header "month date" localizable in thumbnail mode

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
1.4 S1 (14feb)

People

(Reporter: flod, Assigned: flod)

Details

Attachments

(2 files)

Clone of bug 968069 (Gallery) for Video app. We need to make the header localizable.
Attached image video.png
Screenshot on Keon, with test value
date-group-header = %B…%Y
I'm getting an error in tests (thumbnail_date_group_test.js), which I can't really understand
ReferenceError: _ is not defined

But at the beginning of the file I also have
navigator.mozL10n = MockL10n;
MediaUtils._ = MockL10n.get;

So everything should work, as it works in video_test.js
I fixed the test locally, now waiting for Travis to run online.

Not sure about the way I did it though (adding a variable declaration of _ in js/thumbnail_date_group.js).
Code works on my keon, all video tests pass, but I have no idea if this create other issues that I don't see.
Restarted unrelated failed marionette job on travis https://travis-ci.org/mozilla-b2g/gaia/jobs/18722710
Comment on attachment 8374679 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16202

Patch looks good, r+ from me. Thanks for the fix.
Attachment #8374679 - Flags: review?(pdahiya) → review+
Keywords: checkin-needed
Master: 9f36dbb491c29c414fae21dcdbda557e24eb28c3
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
Verified on 1.4 (2014-03-02, git 46b455c9)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.