971639 - [MediaEncoder] Support fragment 3GP format

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Alfredo Yang (:alfredo)]

Spec: http://www.3gpp.org/DynaReport/26244.htm

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: generate_3gp

1. Add '3gp9' brand name.
2. Add AudioSampleEntry and VisualSampleEntry boxes as the based class for audio/video codec box.

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: generate_3gp

1. Correct the class inheritance of SampleEntryBox, VisualSampleEntryBox, AudioSampleEntryBox, MP4AudioSampleEntryBox and AVCSampleEntryBox.
2. Add 3GP ftyp brand names.
3. Add 3GP, MP4 flags in ISOMediaWriter.h

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8377363 [details] [diff] [review]
generate_3gp

Review of attachment 8377363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Sorry for the delay in reviewing this!

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Chris Pearce (:cpearce) from comment #3)
> Comment on attachment 8377363 [details] [diff] [review]
> generate_3gp
> 
> Review of attachment 8377363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Sorry for the delay in reviewing this!

Thanks for review. :-)

Comment 5

[Alfredo Yang (:alfredo)]

https://tbpl.mozilla.org/?tree=Try&rev=cb4bf88c4beb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b217d48ad644

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b217d48ad644