Closed Bug 971639 Opened 6 years ago Closed 6 years ago

[MediaEncoder] Support fragment 3GP format

Categories

(Core :: Audio/Video: Recording, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: ayang, Assigned: ayang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ft:multimedia-platform][m+])

Attachments

(1 file, 1 obsolete file)

Attached patch generate_3gp (obsolete) — Splinter Review
1. Add '3gp9' brand name.
2. Add AudioSampleEntry and VisualSampleEntry boxes as the based class for audio/video codec box.
Attachment #8375393 - Flags: review?(cpearce)
Blocks: MediaEncoder
Attachment #8375393 - Flags: review?(cpearce)
Attached patch generate_3gpSplinter Review
1. Correct the class inheritance of SampleEntryBox, VisualSampleEntryBox, AudioSampleEntryBox, MP4AudioSampleEntryBox and AVCSampleEntryBox.
2. Add 3GP ftyp brand names.
3. Add 3GP, MP4 flags in ISOMediaWriter.h
Attachment #8375393 - Attachment is obsolete: true
Attachment #8377363 - Flags: review?(cpearce)
Blocks: 973765
Target Milestone: --- → 1.4 S2 (28feb)
Whiteboard: [ft:multimedia-platform]
Blocks: 971641
Comment on attachment 8377363 [details] [diff] [review]
generate_3gp

Review of attachment 8377363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Sorry for the delay in reviewing this!
Attachment #8377363 - Flags: review?(cpearce) → review+
(In reply to Chris Pearce (:cpearce) from comment #3)
> Comment on attachment 8377363 [details] [diff] [review]
> generate_3gp
> 
> Review of attachment 8377363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Sorry for the delay in reviewing this!

Thanks for review. :-)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b217d48ad644
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Video/Audio → Video/Audio: Recording
Whiteboard: [ft:multimedia-platform] → [ft:multimedia-platform][m+]
You need to log in before you can comment on or make changes to this bug.