[MediaEncoder] Support fragment 3GP format

RESOLVED FIXED in 1.4 S2 (28feb)

Status

()

Core
Audio/Video: Recording
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alfredo, Assigned: alfredo)

Tracking

(Blocks: 1 bug)

unspecified
1.4 S2 (28feb)
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:multimedia-platform][m+])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Spec: http://www.3gpp.org/DynaReport/26244.htm
(Assignee)

Comment 1

4 years ago
Created attachment 8375393 [details] [diff] [review]
generate_3gp

1. Add '3gp9' brand name.
2. Add AudioSampleEntry and VisualSampleEntry boxes as the based class for audio/video codec box.
(Assignee)

Updated

4 years ago
Attachment #8375393 - Flags: review?(cpearce)

Updated

4 years ago
Blocks: 879688
(Assignee)

Updated

4 years ago
Attachment #8375393 - Flags: review?(cpearce)
(Assignee)

Comment 2

4 years ago
Created attachment 8377363 [details] [diff] [review]
generate_3gp

1. Correct the class inheritance of SampleEntryBox, VisualSampleEntryBox, AudioSampleEntryBox, MP4AudioSampleEntryBox and AVCSampleEntryBox.
2. Add 3GP ftyp brand names.
3. Add 3GP, MP4 flags in ISOMediaWriter.h
Attachment #8375393 - Attachment is obsolete: true
Attachment #8377363 - Flags: review?(cpearce)

Updated

4 years ago
Blocks: 973765

Updated

4 years ago
Target Milestone: --- → 1.4 S2 (28feb)

Updated

4 years ago
Whiteboard: [ft:multimedia-platform]
(Assignee)

Updated

4 years ago
Blocks: 971641
Comment on attachment 8377363 [details] [diff] [review]
generate_3gp

Review of attachment 8377363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Sorry for the delay in reviewing this!
Attachment #8377363 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Chris Pearce (:cpearce) from comment #3)
> Comment on attachment 8377363 [details] [diff] [review]
> generate_3gp
> 
> Review of attachment 8377363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Sorry for the delay in reviewing this!

Thanks for review. :-)
(Assignee)

Comment 5

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=cb4bf88c4beb
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/b217d48ad644
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b217d48ad644
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: Video/Audio → Video/Audio: Recording

Updated

4 years ago
Whiteboard: [ft:multimedia-platform] → [ft:multimedia-platform][m+]
You need to log in before you can comment on or make changes to this bug.