Closed
Bug 971849
Opened 12 years ago
Closed 12 years ago
Implement new Webmaker auth for popcorn.webmaker.org
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Webmaker Graveyard
Popcorn Maker
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jon, Assigned: thecount)
References
Details
(Whiteboard: login2-followup)
Attachments
(1 file)
Once all the new Webmaker auth components are ready, we'll need to implement them in popcorn.webmaker.org.
|
||
Updated•12 years ago
|
Whiteboard: login2
|
|
||
Updated•12 years ago
|
Whiteboard: login2 → login2-followup
|
|
||
Updated•12 years ago
|
Assignee: nobody → scott
|
|
||
Comment 1•12 years ago
|
||
TODO: post links to example implementaiton
Assignee: scott → nobody
Flags: needinfo?(kate)
|
|
||
Updated•12 years ago
|
Assignee: nobody → scott
Flags: needinfo?(kate)
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•12 years ago
|
||
Completely functional https://github.com/mozilla/popcorn.webmaker.org/pull/460
Needs to be cleaned up, and needs the remains of the old login removed.
Also needs a lot of testing.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #8379164 -
Flags: review?(cade)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8379164 -
Flags: review?(schranz.m)
|
|
||
Updated•12 years ago
|
Attachment #8379164 -
Attachment mime type: text/plain → text/x-github-pull-request
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8379164 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/460/files
Couple of things to look at - comments in the pull request.
Attachment #8379164 -
Flags: review?(cade) → review-
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 8379164 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/460/files
Updates
Attachment #8379164 -
Flags: review- → review?(cade)
|
||
Updated•12 years ago
|
Attachment #8379164 -
Flags: review?(schranz.m)
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8379164 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/460/files
update the webmaker-auth package to 0.0.11
Attachment #8379164 -
Flags: review?(cade) → review-
|
|
||
Comment 7•12 years ago
|
||
https://github.com/ScottDowne/popcorn.webmaker.org/blob/t971849/routes/api/publish.js#L31
needs to be changed to check for / use `req.session.user.username`
|
|
||
Comment 8•12 years ago
|
||
https://gist.github.com/cadecairos/805ffeb259eb8d4ca767
there's many instances where popcorn tries to read user data directly from the session object, but we've changed the session object with the new auth strategy - needs to look on `request.session.user`
|
|
Assignee | |
Comment 9•12 years ago
|
||
Comment on attachment 8379164 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/460/files
Updated.
I cannot update to 0.0.11 until it is on the mirror.
Attachment #8379164 -
Flags: review- → review?(cade)
|
|
Assignee | |
Comment 10•12 years ago
|
||
Fine, no longer using the mirror...
|
|
||
Comment 11•12 years ago
|
||
Comment on attachment 8379164 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/460/files
I think we're ready to get this on staging for testing.
Attachment #8379164 -
Flags: review?(cade) → review+
|
|
Assignee | |
Comment 12•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/6c9b2cdfd7e8f3426c80c26b39cd52d6888938ea
Needs verification.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in
before you can comment on or make changes to this bug.
Description
•