960727 - [meta] Refresh Webmaker auth system

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Brett Gaylor [:brett]]

Based on the architecture of the new events and profile apps, we should reconsider our auth solution.

Comment 2

[Jon Buckley [:jbuck]]

Initial thoughts on a new login system, done with cade and kate: https://etherpad.mozilla.org/newwebmakerlogin

Comment 3

[David Humphrey (:humph)]

As soon as it makes sense, that etherpad's contents should get copied into this bug so it doesn't get lost/disconnected from this bug.

Also, what you're proposing looks interesting.

Comment 4

[inactivate account for kate]

I did some rough work on an implementation on the client-side part of our ideas here (no tests or AMD): https://github.com/k88hudson/webmaker-auth-client.

I wanted to test:
- Saving tokens/user data in local storage
- Restoring state instantly from a previous session and silently verifying 
- Managing errors and login/logout state with events

I'd also like to try adding the create a new user panel etc. which I suspect will be the most challenging aspect of the front-end, but I figured I wouldn't go too far before we do back-end work.

Comment 5

[Jon Buckley [:jbuck]]

Lots and lots of background research on Oauth 1.0 and Oauth 2.0 done by Kate: https://docs.google.com/document/d/1m5kZsHwPuDNPwSrdBX4kb7pUHUd4RrhYAKB8AUQvQSc/edit#
Notes on what the new login system will have in terms of API responses: https://docs.google.com/document/d/165CpDWlNPXEfU5LK4KcjdvgZGHvlJr2zhau8NAXBQCg/edit#

Comment 6

[Jon Buckley [:jbuck]]

Attachment: Diagram of login flow

Comment 7

[Jon Buckley [:jbuck]]

Attachment: Description of steps in login flow

Comment 8

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/233

Adding my PR until I file the bug for it

Comment 9

[Jon Buckley [:jbuck]]

Attachment: Etherpad contents

Comment 10

[Jon Buckley [:jbuck]]

Cade will wrangle this to make sure it gets done

Comment 11

[inactivate account for kate]

Oh look, all the dependencies are cleared.