972042 - Audit UITest's use of Solo.getView

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

As discovered by margaret [1], Solo.getView throws an assertion when it can't find a view. We should comb through the UITest framework code and ensure this is not misused (and to remove any null checks because it just won't happen!).

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=935264#c2

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
> As discovered by margaret [1], Solo.getView throws an assertion when it
> can't find a view.

Looking through the source, I can't find this (i.e. `getView` returns null) nor can I repro locally.

Note that these assumptions may change with Robotium 5.1 (bug 988295).

While I might be going crazy, I think it's just case and point to audit this.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that this line may also be problematic: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/BaseTest.java?rev=9402c13b1475#197

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Unassigning this bug due to inactivity. Feel free to take it back if you plan on working on it, Vivek.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via research in bug 1113754 comment 4: Also note that we can use waitForView, as per [1], to have more control over getView results and, if we use it on all of our views, potentially avoid further bugs where views momentarially disappear and reappear - this is inefficient but if the user never notices then it shouldn't matter - these tests are to test what the user sees.

[1]: https://hg.mozilla.org/mozilla-central/annotate/67872ce17918/mobile/android/base/tests/components/AboutHomeComponent.java#l72

Comment 5

[Geoff Brown [:gbrown]]

Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.