Closed Bug 972055 Opened 12 years ago Closed 12 years ago

404 on storage returns HTML body

Categories

(Cloud Services Graveyard :: Server: Sync, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rnewman, Assigned: rfkelly)

Details

(Whiteboard: [qa?])

Attachments

(1 file)

02-12 15:06:20.671 I/FxAccounts(15257): fennec_rnewman :: GlobalSession :: Running next stage fetchMetaGlobal (org.mozilla.gecko.sync.stage.FetchMetaGlobalStage@214b7df0)... 02-12 15:06:20.801 W/FxAccounts(15257): fennec_rnewman :: SSResourceDelegate :: HTTP request failed. 02-12 15:06:20.801 W/FxAccounts(15257): fennec_rnewman :: SSResourceDelegate :: HTTP response body: <html> 02-12 15:06:20.801 W/FxAccounts(15257): <head> 02-12 15:06:20.801 W/FxAccounts(15257): <title>404 Not Found</title> 02-12 15:06:20.801 W/FxAccounts(15257): </head> 02-12 15:06:20.801 W/FxAccounts(15257): <body> 02-12 15:06:20.801 W/FxAccounts(15257): <h1>404 Not Found</h1> 02-12 15:06:20.801 W/FxAccounts(15257): The resource could not be found.<br/><br/> 02-12 15:06:20.801 W/FxAccounts(15257): 02-12 15:06:20.801 W/FxAccounts(15257): 02-12 15:06:20.801 W/FxAccounts(15257): 02-12 15:06:20.801 W/FxAccounts(15257): </body> 02-12 15:06:20.801 W/FxAccounts(15257): </html> Seems undesirable.
I guess this is just the default pyramid response objects; we should intercept them and put in a different body. JSON with weave error number?
Assignee: nobody → rfkelly
Whiteboard: [qa?]
We also observed this for 503 responses
Here's a rather blunt instrument to avoid this - intercept any non-json responses and coerce them into json with a default error code. They won't be any more useful to the client, but at least they wont trigger extra debug logging.
Attachment #8376941 - Flags: review?(telliott)
Attachment #8376941 - Flags: review?(telliott) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Priority: -- → P2
Verified in code and with the unit tests.
Status: RESOLVED → VERIFIED
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: