Closed Bug 972382 Opened 6 years ago Closed 6 years ago

[GTK3] Theme is not loaded in other WM's (MATE, XFCE and so)

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #627699 +++

Gtk3 fails to load theme without gtk_settings_get_for_screen() call.

RH BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1064922
Gnome BZ: https://bugzilla.gnome.org/show_bug.cgi?id=696428
Attached patch patch (obsolete) — Splinter Review
Attachment #8375526 - Flags: review?(karlt)
Can you add a comment to explain what side effect gtk_settings_get_for_screen() is having here, please?
I guess this a problem with the css provider for GtkStyleContext being set with a push from gtk_settings_get_for_screen() instead of GtkStyleContext initializing this when required.  How is that related to https://bugzilla.gnome.org/show_bug.cgi?id=696428?
Flags: needinfo?(stransky)
I don't think https://bugzilla.gnome.org/show_bug.cgi?id=696428 is related.

The bug is that GTK manages a screen's CSS in the settings object. As a result of that, the CSS is loaded when the settings result is created. Until then no theme is loaded.

So the workaround is to create the settings object, which is what the patch does.
Comment on attachment 8375526 [details] [diff] [review]
patch

The code change is fine, but please remove the reference to 696428 and add an explanation comment.
Attachment #8375526 - Flags: review?(karlt) → review+
Thanks! There's the updated one.
Flags: needinfo?(stransky)
Keywords: checkin-needed
Attachment #8375526 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/b3b8d7286243
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Blocks: 1034064
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.