Closed
Bug 972608
Opened 12 years ago
Closed 11 years ago
Update the Feedback charm string
Categories
(Firefox for Metro Graveyard :: Flyouts, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 30
People
(Reporter: jimm, Assigned: jimm)
References
()
Details
(Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff30)
Attachments
(2 files, 2 obsolete files)
|
48.54 KB,
image/png
|
Details | |
|
4.74 KB,
patch
|
sfoster
:
review+
|
Details | Diff | Splinter Review |
example (music app)
The current string is "Sumbit Feedback...". The convention however is to use a single word without an ellipsis.
|
Assignee | |
Comment 1•12 years ago
|
||
for landing on mc only, no uplift.
Assignee: nobody → jmathies
Attachment #8375847 -
Flags: review?(sfoster)
|
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 2•12 years ago
|
||
Making this "Feedback (online)" per the ms spec guidelines.
Attachment #8375847 -
Attachment is obsolete: true
Attachment #8375847 -
Flags: review?(sfoster)
Attachment #8376172 -
Flags: review?(sfoster)
|
|
Assignee | |
Comment 3•12 years ago
|
||
- removed the old hack code
- moved the url into prefs
Attachment #8376172 -
Attachment is obsolete: true
Attachment #8376172 -
Flags: review?(sfoster)
Attachment #8376179 -
Flags: review?(sfoster)
|
||
Updated•12 years ago
|
Blocks: metrobacklog
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: jbecerra
Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff28
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8376179 [details] [diff] [review]
fix v.3
Review of attachment 8376179 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great, thanks for doing this.
Attachment #8376179 -
Flags: review?(sfoster) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
|
||
Updated•11 years ago
|
Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff28 → p=1 s=it-30c-29a-28b.1 r=ff30
|
||
Comment 7•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Verified as fixed on latest Nightly (Build ID: 20140217030202) using a Windows 8.1 64bit machine and a Microsoft Surface Pro 2 device running 8.1 64bit.
The charm string is now "Feedback (online)".
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•