Open Bug 972658 Opened 9 years ago Updated 2 months ago
Undo 'restore defaults' does not restore toolbar visibility (bookmarks / menu toolbar )
The 'undo restore defaults' action should restore the visibility of the bookmarks toolbar or alternatively the 'restore defaults' action should not change the visibility of the bookmarks toolbar, currently it's a 'partial undo'. Also it's has no effect for the titlebar setting. STR: 1. enable the bookmark toolbar 2. open about:customizing 3. click the button 'Restore Defaults' 4. click the link 'Undo' Expected: No bookmarks toolbar after step 3, visible bookmarks toolbar after step 4 Actual: No bookmarks toolbar after step 3 and no bookmarks toolbar after step 4
Depends on: 970511
Summary: Australis: Undo 'restore defaults' does not restore bookmark toolbar → Australis: Undo 'restore defaults' does not restore bookmarks toolbar
Thank you for reporting this. See bug 971626 with respect to the titlebar.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: Trunk → 29 Branch
Please note this bug applies to Menu Bar as well, i.e. it doesn't get re-enabled when clicking "Restore Defaults" and then "Undo". Should I file this as a separate bug? If not, then perhaps it'd be appropriate to change the summary of this bug to "Australis: Undo 'restore defaults' does not restore enabled toolbars".
This bug can be used for all toolbars. I'll update the summary.
Summary: Australis: Undo 'restore defaults' does not restore bookmarks toolbar → Australis: Undo 'restore defaults' does not restore toolbar visibility
If someone wants to contribute a patch, this probably involves adding toolbar state into the "state before reset" code in https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2605-2612 , and then restoring it in undoReset, https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2660 . It'll need to take appropriate care of multiple windows, which toolbars are/aren't collapsed by default, and persisting the attributes. See also e.g. https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2644-2652 . And we should add a test... As it is, I don't think this will be a priority for the core team really soon.
Priority: -- → P3
Version: 29 Branch → Trunk
Summary: Australis: Undo 'restore defaults' does not restore toolbar visibility → Undo 'restore defaults' does not restore toolbar visibility (bookmarks / menu toolbar )
You need to log in before you can comment on or make changes to this bug.