972658 - Undo 'restore defaults' does not restore toolbar visibility (bookmarks / menu toolbar )

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Sören Hentzschel]

The 'undo restore defaults' action should restore the visibility of the bookmarks toolbar or alternatively the 'restore defaults' action should not change the visibility of the bookmarks toolbar, currently it's a 'partial undo'. Also it's has no effect for the titlebar setting.

STR:

1. enable the bookmark toolbar
2. open about:customizing
3. click the button 'Restore Defaults'
4. click the link 'Undo'

Expected:

No bookmarks toolbar after step 3, visible bookmarks toolbar after step 4

Actual:

No bookmarks toolbar after step 3 and no bookmarks toolbar after step 4

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Thank you for reporting this. See bug 971626 with respect to the titlebar.

Comment 2

[jaramat]

Please note this bug applies to Menu Bar as well, i.e. it doesn't get re-enabled when clicking "Restore Defaults" and then "Undo".

Should I file this as a separate bug? If not, then perhaps it'd be appropriate to change the summary of this bug to "Australis: Undo 'restore defaults' does not restore enabled toolbars".

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This bug can be used for all toolbars. I'll update the summary.

Comment 4

[magicp]

Attachment: customize-restoredefaults-undo.mp4

Comment 5

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Update_affecteds

Comment 7

[:Gijs (he/him)]

If someone wants to contribute a patch, this probably involves adding toolbar state into the "state before reset" code in https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2605-2612 , and then restoring it in undoReset, https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2660 . It'll need to take appropriate care of multiple windows, which toolbars are/aren't collapsed by default, and persisting the attributes. See also e.g. https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/components/customizableui/CustomizableUI.jsm#2644-2652 . And we should add a test...

As it is, I don't think this will be a priority for the core team really soon.