972695 - [dsds] support Sim Manager in Settings on dsds phone

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Eric Chang [:ericcc] [:echang]]

https://moztrap.mozilla.org/manage/case/10590/
Change default sim for call/sms/data

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: PR 16162

Comment 2

[Zac C (:zac)]

Comment on attachment 8376924 [details] [review]
PR 16162

Test case does not match Moztrap case closely.

Comment 3

[Eric Chang [:ericcc] [:echang]]

Adding test case to check default and settings can be changed.

Comment 4

[Zac C (:zac)]

Comment on attachment 8376924 [details] [review]
PR 16162

r-, needs some more refinements. there's too much unnecessary code. Less is more!!

Comment 5

[Eric Chang [:ericcc] [:echang]]

Comment on attachment 8376924 [details] [review]
PR 16162

'Select' behavior for 'Data' is quite different from that for Call and SMS after modification of https://bugzilla.mozilla.org/show_bug.cgi?id=974828

Normal Select: Tap on specific item -> tap Ok of that page -> then to go back to app.
Select for Data: Tap on specific item -> confirmation shown -> tap Ok to go back to app.

Comment 6

[Zac C (:zac)]

Comment on attachment 8376924 [details] [review]
PR 16162

Some small nitpicks on little things but aside from that it looks good now :)

Comment 7

[Eric Chang [:ericcc] [:echang]]

Comment on attachment 8376924 [details] [review]
PR 16162

I git push another commit to fix the things in your previous comments, not merge them together.

Comment 8

[Zac C (:zac)]

Comment on attachment 8376924 [details] [review]
PR 16162

I can't test it because I don't have a fugu, but r+

Comment 9

[Eric Chang [:ericcc] [:echang]]

Thanks I will attach a video next time
http://www.youtube.com/watch?v=u71QS0JIOlU

Comment 10

[Zac C (:zac)]

(In reply to Eric Chang [:ericcc] [:echang] from comment #9)
> Thanks I will attach a video next time
> http://www.youtube.com/watch?v=u71QS0JIOlU

:DD very good!

When Askeing gives it r+ he can merge.

Comment 11

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8376924 [details] [review]
PR 16162

LGTM, merged https://github.com/mozilla-b2g/gaia/commit/cfeb141baf310fa105cdfe3ce616f2e0336401d1