[NFC] landscape NFC shrinking UI has some issue

RESOLVED FIXED

Status

Firefox OS
NFC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ypwalter, Assigned: snowmantw)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mwcdemo2013])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
lastest(2/14) mako build on master branch

steps:
0. enable NFC
1. launch browser
2. turn the phone to landscape view, and tap phones together

expected result:
the shrinking UI comes out without issues
        ^
        |
   ___________
   |         |
   |         |
   -----------

actaul result:
the arrow is kind of blocked

        ^
   -----------
   |         |
   |         |
   -----------


 UX/designed is working on a document/example now. please ask fang or juwei for it.
(Reporter)

Comment 1

4 years ago
Hi, Fang and Juwei,
If you can provide us with document/example or make it right with dev or others, it will be wonderful.

Thanks.
Flags: needinfo?(jhuang)
Flags: needinfo?(fshih)
(Reporter)

Comment 2

4 years ago
PS. the same issue applies to image/video sharing.
(Reporter)

Updated

4 years ago
Blocks: 894678

Comment 3

4 years ago
Leave Fang to comment, she'll update visual spec later.
Flags: needinfo?(jhuang)

Comment 4

4 years ago
Created attachment 8376108 [details]
NFC_Landscape.zip

Update the visual of landscape view. Specs attached. 
Thanks!
Flags: needinfo?(fshih)
(Reporter)

Updated

4 years ago
Blocks: 972791

Comment 5

4 years ago
Assign this bug to you. If it is a wrong assignment, please let me know.
Assignee: nobody → gweng
(Reporter)

Updated

4 years ago
Whiteboard: [mwcdemo2013]
(Assignee)

Comment 6

4 years ago
Created attachment 8379433 [details] [review]
Patch

Fixed this with some orientation detection code.
Attachment #8379433 - Flags: review?(alive)
Attachment #8379433 - Flags: review?(alive) → review+
(Assignee)

Comment 7

4 years ago
master: https://github.com/mozilla-b2g/gaia/commit/caba3345a48d9b2561220405820c361a6b6f16a8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.