Closed Bug 973195 Opened 6 years ago Closed 6 years ago

[e10s] Copy link doesn't work

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I debugged this. I a while back I added that code that pipes goDoCommand to the child, which is already a hack (I really wish we didn't have this system at all) Basically what happens is that we end up calling nsDocumentViewer::GetPopupLinkNode, when we invoke isCommandEnabled("cmd_copyLink"), to find out over which link the context menu got opened. This however doesn't work, because the context menu was opened in the parent and not the child. I think the easiest fix is to just stop using doCommand here. We already have a reference to the link, so we might as well copy the location to the clipboard in nsContextMenu.js.
Summary: Copy link doesn't work → [e10s] Copy link doesn't work
Assignee: nobody → evilpies
Comment on attachment 8380371 [details] [diff] [review]
copy-link

I think we should be fine.
Attachment #8380371 - Flags: review?(felipc)
Comment on attachment 8380371 [details] [diff] [review]
copy-link

Review of attachment 8380371 [details] [diff] [review]:
-----------------------------------------------------------------

Just pasting these links that evilpie posted on IRC for my own reference:

4:35 PM <@evilpie> http://dxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindowCommands.cpp#506
4:36 PM <@evilpie> http://dxr.mozilla.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#2536
Attachment #8380371 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/292b56144007
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
No longer blocks: fxdesktopbacklog
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.