973195 - [e10s] Copy link doesn't work

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tom S [:evilpie]]

I debugged this. I a while back I added that code that pipes goDoCommand to the child, which is already a hack (I really wish we didn't have this system at all) Basically what happens is that we end up calling nsDocumentViewer::GetPopupLinkNode, when we invoke isCommandEnabled("cmd_copyLink"), to find out over which link the context menu got opened. This however doesn't work, because the context menu was opened in the parent and not the child. I think the easiest fix is to just stop using doCommand here. We already have a reference to the link, so we might as well copy the location to the clipboard in nsContextMenu.js.

Comment 1

[Tom S [:evilpie]]

Attachment: copy-link

We will see how it goes: https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 2

[Tom S [:evilpie]]

Comment on attachment 8380371 [details] [diff] [review]
copy-link

I think we should be fine.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8380371 [details] [diff] [review]
copy-link

Review of attachment 8380371 [details] [diff] [review]:
-----------------------------------------------------------------

Just pasting these links that evilpie posted on IRC for my own reference:

4:35 PM <@evilpie> http://dxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindowCommands.cpp#506
4:36 PM <@evilpie> http://dxr.mozilla.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#2536

Comment 4

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/292b56144007

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/292b56144007