Closed
Bug 973448
Opened 10 years ago
Closed 10 years ago
[settings] refactor Support panel with AMD pattern
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(1 file, 1 obsolete file)
Overview Description: Refactor Support panel with AMD pattern referring to https://github.com/crh0716/gaia/tree/settings2_iterative to make it modularize and more easier to maintain Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Expected Results: pass all settings test and act the same as original implementation Additional Information:
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gasolin
Assignee | ||
Comment 1•10 years ago
|
||
porting https://github.com/crh0716/gaia/commit/b16458aeaf5ffb20104a4913b0453013b5c1dcb5 to gaia master
Assignee | ||
Comment 2•10 years ago
|
||
WIP https://github.com/mozilla-b2g/gaia/pull/16688
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8384544 [details] [review] pull request redirect to github ported from settings2 branch
Attachment #8384544 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 5•10 years ago
|
||
put panel modules in panel/support folder
Attachment #8384544 -
Attachment is obsolete: true
Attachment #8384544 -
Flags: review?(arthur.chen)
Attachment #8393930 -
Flags: review?(arthur.chen)
Comment 6•10 years ago
|
||
Comment on attachment 8393930 [details] [review] pull request redirect to github Thanks for the patch! In general it looks good. For this panel we need unit tests ensuring the data stored in the json file (we can mock the loadJSON function) are rendered correctly. It might be easier to break the large functions into smaller ones and add tests for each of them. Please check my comments in github.
Attachment #8393930 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8393930 [details] [review] pull request redirect to github fix addressed comment, refactor and add test cases
Attachment #8393930 -
Flags: review?(arthur.chen)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 8•10 years ago
|
||
Comment on attachment 8393930 [details] [review] pull request redirect to github Thanks for the effort, Fred! Please check my comments in github.
Attachment #8393930 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8393930 [details] [review] pull request redirect to github fixed addressed issues, please kindly review it again, thanks.
Attachment #8393930 -
Flags: review?(arthur.chen)
Comment 10•10 years ago
|
||
Comment on attachment 8393930 [details] [review] pull request redirect to github r=me, thank you!
Attachment #8393930 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 11•10 years ago
|
||
merged and README updated https://github.com/mozilla-b2g/gaia/commit/04d96dd43e2c5c673a0c73b5a65faeb115c2065f thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•