973448 - [settings] refactor Support panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Support panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[[e-mail]]

porting https://github.com/crh0716/gaia/commit/b16458aeaf5ffb20104a4913b0453013b5c1dcb5
to gaia master

Comment 2

[[e-mail]]

WIP https://github.com/mozilla-b2g/gaia/pull/16688

Comment 3

[[e-mail]]

Attachment: pull request redirect to github

Comment 4

[[e-mail]]

Comment on attachment 8384544 [details] [review]
pull request redirect to github

ported from settings2 branch

Comment 5

[[e-mail]]

Attachment: pull request redirect to github

put panel modules in panel/support folder

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393930 [details] [review]
pull request redirect to github

Thanks for the patch! In general it looks good. For this panel we need unit tests ensuring the data stored in the json file (we can mock the loadJSON function) are rendered correctly. It might be easier to break the large functions into smaller ones and add tests for each of them. Please check my comments in github.

Comment 7

[[e-mail]]

Comment on attachment 8393930 [details] [review]
pull request redirect to github

fix addressed comment, refactor and add test cases

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393930 [details] [review]
pull request redirect to github

Thanks for the effort, Fred! Please check my comments in github.

Comment 9

[[e-mail]]

Comment on attachment 8393930 [details] [review]
pull request redirect to github

fixed addressed issues, please kindly review it again, thanks.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393930 [details] [review]
pull request redirect to github

r=me, thank you!

Comment 11

[[e-mail]]

merged and README updated https://github.com/mozilla-b2g/gaia/commit/04d96dd43e2c5c673a0c73b5a65faeb115c2065f

thanks!