Closed Bug 973448 Opened 7 years ago Closed 7 years ago

[settings] refactor Support panel with AMD pattern

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
Overview Description:

Refactor Support panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:
Assignee: nobody → gasolin
Attached file pull request redirect to github (obsolete) —
Comment on attachment 8384544 [details] [review]
pull request redirect to github

ported from settings2 branch
Attachment #8384544 - Flags: review?(arthur.chen)
put panel modules in panel/support folder
Attachment #8384544 - Attachment is obsolete: true
Attachment #8384544 - Flags: review?(arthur.chen)
Attachment #8393930 - Flags: review?(arthur.chen)
Comment on attachment 8393930 [details] [review]
pull request redirect to github

Thanks for the patch! In general it looks good. For this panel we need unit tests ensuring the data stored in the json file (we can mock the loadJSON function) are rendered correctly. It might be easier to break the large functions into smaller ones and add tests for each of them. Please check my comments in github.
Attachment #8393930 - Flags: review?(arthur.chen)
Comment on attachment 8393930 [details] [review]
pull request redirect to github

fix addressed comment, refactor and add test cases
Attachment #8393930 - Flags: review?(arthur.chen)
Status: NEW → ASSIGNED
Blocks: 956210
Target Milestone: --- → 1.4 S5 (11apr)
Comment on attachment 8393930 [details] [review]
pull request redirect to github

Thanks for the effort, Fred! Please check my comments in github.
Attachment #8393930 - Flags: review?(arthur.chen)
Comment on attachment 8393930 [details] [review]
pull request redirect to github

fixed addressed issues, please kindly review it again, thanks.
Attachment #8393930 - Flags: review?(arthur.chen)
Comment on attachment 8393930 [details] [review]
pull request redirect to github

r=me, thank you!
Attachment #8393930 - Flags: review?(arthur.chen) → review+
merged and README updated https://github.com/mozilla-b2g/gaia/commit/04d96dd43e2c5c673a0c73b5a65faeb115c2065f

thanks!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.