Closed
Bug 973611
Opened 12 years ago
Closed 12 years ago
[Single Variant] Configure keyboard settings through single-variant
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: macajc, Assigned: albert)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Add json to configure keyboard settings depending on the mcc/mnc.
Copy json from distribution folder to the ftu app.
|
Reporter | |
Updated•12 years ago
|
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM
|
||
Updated•12 years ago
|
Whiteboard: [systemsfe]
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → acperez
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8381442 -
Flags: review?(yurenju.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8381442 [details]
Patch
looks good, but could you add a verification in integration test for build script[1]?, it can prevent someone to break it.
[1] https://github.com/mozilla-b2g/gaia/blob/master/build/test/integration/distribution.test.js
Attachment #8381442 -
Flags: review?(yurenju.mozilla)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8381442 [details]
Patch
Added integration tests
Attachment #8381442 -
Flags: review?(yurenju.mozilla)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8381442 [details]
Patch
r=yurenju, thank you!
Attachment #8381442 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Only affects build process.
Master: https://github.com/mozilla-b2g/gaia/commit/12b36271d6ecb49d5fbe9c166dc546c200252d95
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•