973658 - Permanent private browsing revert code path doesn't work properly if coming from "custom settings"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[(no longer active)]

STR:

1. Open about:config, search for autostart so that you can watch the pref.
2. Open Preferences, go to the Privacy tab, ensure that the "Use custom settings for history" item is selected, and change it to "Never remember history".
3. Say Cancel to that dialog.  The autostart pref is not reverted.

Josh, can you please take this?

Comment 1

[(no longer active)]

Actually I know what's going wrong here.

Comment 2

[(no longer active)]

Attachment: Actually revert the value of the Permanent Private Browsing pref when the user presses Cancel in response to the restart dialog; r=jdm

Before we were implicitly relying on the pref being reverted through
the checkbox, but that won't happen if the checkbox was never clicked
by the user.

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/158d923965d3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/158d923965d3

Comment 5

[Tracy Walker [:tracy]]

Verified with latest Nightly build