Closed Bug 973658 Opened 8 years ago Closed 8 years ago

Permanent private browsing revert code path doesn't work properly if coming from "custom settings"

Categories

(Firefox :: Preferences, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

STR:

1. Open about:config, search for autostart so that you can watch the pref.
2. Open Preferences, go to the Privacy tab, ensure that the "Use custom settings for history" item is selected, and change it to "Never remember history".
3. Say Cancel to that dialog.  The autostart pref is not reverted.

Josh, can you please take this?
Flags: needinfo?(josh)
Actually I know what's going wrong here.
Assignee: nobody → ehsan
Flags: needinfo?(josh)
Blocks: 842290
Before we were implicitly relying on the pref being reverted through
the checkbox, but that won't happen if the checkbox was never clicked
by the user.
Attachment #8377212 - Flags: review?(josh)
Attachment #8377212 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/158d923965d3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Verified with latest Nightly build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.