973855 - [Australis] Bottom border of content area in customization mode misplaced or missing

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Peter Retzer (:pretzer)]

When switching to customization mode the bottom border of the content area stays where it is and does animate upwards with the content. Instead it is visible in the glass area at the bottom. I reproduced this on Win7, not sure if other platforms are affected.

Comment 1

[Peter Retzer (:pretzer)]

Attachment: Screenshot of the issue

Comment 2

[:Gijs (he/him)]

I think there's one or more negations missing in:

When switching to customization mode the bottom border of the content area stays where it is and does animate upwards with the content. Instead it is visible in the glass area at the bottom.


Orthogonally, can you reproduce this in safe mode, and/or is this a dupe of bug 970998?

Comment 3

[Peter Retzer (:pretzer)]

(In reply to :Gijs Kruitbosch from comment #2)
> I think there's one or more negations missing in:
Indeed! What I meant was: "... does *NOT* animate upwards ..."

> Orthogonally, can you reproduce this in safe mode, 
Yes, I can reproduce in safe mode.

> and/or is this a dupe of bug 970998?
Does not seem like a dupe to me. That bug is talking about the missing animation, which is intentional AFAICS. I'm talking about a visual glitch, that is probably not intentional.

Comment 5

[Matthew N. [:MattN]]

henryfhchan has a solution in bug 989681 comment 0.

Comment 6

[Matthew N. [:MattN]]

henryfhchan, are you able to submit patches? See http://codefirefox.com/ and/or https://developer.mozilla.org/en-US/docs/Introduction

Comment 7

[Matthew N. [:MattN]]

(In reply to henryfhchan from bug 989681 comment #6)
> Sorry, I haven't written a patch before, and seems like I don't have enough
> disk space to install the related tools...

OK, I'll make it for you if you can test it.

Comment 8

[Matthew N. [:MattN]]

The border is missing altogether outside -moz-windows-compositor. I'll get a separate bug on file for that.

Comment 9

[Matthew N. [:MattN]]

Attachment: WIP - Include browser-bottombox in the customization mode padding

Of course it wasn't so easy.

Despite bug 962677 not including the developer toolbar, I think it should be included in the customization mode padding along with the rest of browser-bottombox since that's where extensions put bottom toolbars (e.g. add-on/status bar replacements) and I think it makes sense for it to shrink along with the rest of the toolbars in customization mode.

Tested on Windows 7, 10.9 HiDPI and Ubuntu x64 but I want to do another sanity check before requesting review since it's late.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8399052 [details] [diff] [review]
WIP - Include browser-bottombox in the customization mode padding

Review of attachment 8399052 [details] [diff] [review]:
-----------------------------------------------------------------

Were there no Windows-specific changes needed? Do you know how this may affect CART? Otherwise, this change looks good, and it has the added benefit of keeping the Developer Toolbar connected to the rest of the content portion of the window when in customization mode.

Comment 11

[Matthew N. [:MattN]]

Attachment: v.1 Include browser-bottombox in the customization mode padding

(In reply to Jared Wein [:jaws] from comment #10)
> Review of attachment 8399052 [details] [diff] [review]:
>
> Were there no Windows-specific changes needed? 

Now that I tested with non-Aero, I have a fix for it too and it fixes comment 8 which I was originally going to do in a separate bug. (The patch was a WIP for feedback because I hadn't manually tested as much as I wanted to).

> Do you know how this may affect CART?

We'll find out:

Baseline: https://tbpl.mozilla.org/?tree=Try&rev=feb96cf59e30
Patch: https://tbpl.mozilla.org/?tree=Try&rev=91b5642bbfc3

Comparison: http://compare-talos.mattn.ca/?oldRevs=feb96cf59e30&newRev=91b5642bbfc3&submit=true

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8401181 [details] [diff] [review]
v.1 Include browser-bottombox in the customization mode padding

Review of attachment 8401181 [details] [diff] [review]:
-----------------------------------------------------------------

CART results look fine, only a teeny-tiny regression (.66%) on Win7.

Comment 13

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/5cb220a0c88f

Comment 14

[Matthew N. [:MattN]]

Comment on attachment 8401181 [details] [diff] [review]
v.1 Include browser-bottombox in the customization mode padding

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 873060
User impact if declined: There will be a floating detached bottom border with DWM in customization mode and no bottom border without DWM. This also makes it so that toolbars on the bottom of the browser contract with the rest of the toolbars which is more consistent IMO.
Testing completed (on m-c, etc.): m-c soon
Risk to taking this patch (and alternatives if risky): Low risk CSS changes to margin and border.
String or IDL/UUID changes made by this patch: None

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5cb220a0c88f

Comment 16

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/61fdd94d78fe

Comment 17

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/75c7e2c98e0c

Comment 18

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on Windows 7 64-bit [1] using:
- the latest Beta (Build ID: 20140407135746),
- the latest Aurora 2014-04-07 (Build ID: 20140407004002),
- the latest Nightly 2014-04-07 (Build ID: 20140407030203).


1. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0