Closed
Bug 973880
Opened 11 years ago
Closed 11 years ago
Faulty: TextureHost should validate immediately TextureFlags consistency without assertions
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 968872
People
(Reporter: bjacob, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
7.97 KB,
text/plain
|
Details | |
|
3.22 KB,
patch
|
Details | Diff | Splinter Review |
Found by Christoph Diehl's "Faulty" fuzzer, see bug 777067
TextureFlags come from untrusted message params, so we must validate them immediately before creating a TextureHost, and not by an assertion.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #8378007 -
Flags: review?(nical.bugzilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8378007 [details] [diff] [review]
ValidateTextureFlags
Review of attachment 8378007 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/CompositorTypes.h
@@ +92,5 @@
> +inline bool
> +ValidateTextureFlags(TextureFlags aFlags)
> +{
> + if ((aFlags & TEXTURE_DEALLOCATE_CLIENT) &&
> + (aFlags & TEXTURE_DEALLOCATE_DEFERRED))
TEXTURE_DEALLOCATE_DEFERRED is being removed by a patch from sotaro.
Attachment #8378007 -
Flags: review?(nical.bugzilla)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Great, can you link to the corresponding bug?
|
|
Reporter | |
Comment 4•11 years ago
|
||
That's bug 968872. Duping.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•