974102 - [Camera][Madai] 1.4 Recording Timer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Attachment: Dual_Shutter_Video_Spec.png

The video timer has a new design and has moved to the top left corner.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: WIP - New recording timer, old timer not yet removed

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request #61 to dmarcos/camera-dev

Comment 3

[Diego Marcos [:dmarcos]]

landed in camera-dev

Comment 4

[Diego Marcos [:dmarcos]]

Attachment: pull-request (camera-new-features)

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8385842 [details] [review]
pull-request (camera-new-features)

r+ with nits addressed and with code added to handle all camera orientations.

See github comments: https://github.com/dmarcos/gaia/commit/9a7bc6ffcc2c0d606cd9caad5fddb3de1aaba6aa

It looks like this was originally a nice clean patch that got rebased on top of dirty patches with random changes, so now the patch reverts some of the random changes from earlier patches.  I think you'll have to clean that stuff up, but hopefully we can just land this, even if we do it out of order.

In the CSS file you need to use rems instead of px.

Please attach screenshots for ux review.

Comment 6

[Diego Marcos [:dmarcos]]

Landed in camera-new-features as part of bug 971086:

https://github.com/mozilla-b2g/gaia/commit/ce8e2cc83b6db75e6cd30d556905815a4a90baa9