Closed
Bug 974135
Opened 11 years ago
Closed 11 years ago
Get rid of NS_IMETHOD in nsISVGChildFrame.h (and NS_IMETHODIMP in method-implementations)
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Six, Assigned: Six)
References
Details
Attachments
(1 file, 1 obsolete file)
25.90 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Spin-off from bug 919806, comment 13
We should be able to remove all of the NS_IMETHOD in nsISVGChildFrame.h
For every NS_IMETHOD in nsISVGChildFrame.h, we should replace it with "virtual nsresult" and NS_IMETHOD_(foo) whith virtual foo.
And similar for any implementations of the methods that we change, except there it'll be NS_IMETHODIMP.
To start:
http://mxr.mozilla.org/mozilla-central/source/layout/svg/nsISVGChildFrame.h
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → six.dsn
Version: unspecified → Trunk
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
replaces all NS_IMETHOD from nsISVGChildFrame.h and child classes in layout/svg/
Attachment #8378460 -
Flags: review?(dholbert)
Comment 2•11 years ago
|
||
Comment on attachment 8378460 [details] [diff] [review]
remove_SVG_nsimethod.patch
Looks good to me! Could you give this a Try run? (probably just testing that it compiles successfully on Windows; that's really the only thing that could break, if this were missing a piece)
>+++ b/layout/svg/nsSVGImageFrame.cpp
[...]
> // nsISVGChildFrame interface:
>- NS_IMETHOD PaintSVG(nsRenderingContext *aContext, const nsIntRect *aDirtyRect,
>+ virtual nsresult PaintSVG(nsRenderingContext *aContext, const nsIntRect *aDirtyRect,
> nsIFrame* aTransformRoot) MOZ_OVERRIDE;
>- NS_IMETHOD_(nsIFrame*) GetFrameForPoint(const nsPoint &aPoint);
>+ virtual nsIFrame* GetFrameForPoint(const nsPoint &aPoint);
> virtual void ReflowSVG();
Observation: Looks like GetFrameForPoint and ReflowSVG here could both use a MOZ_OVERRIDE annotation. Same goes for AttributeChanged, DestroyFrom, GetType, and GetFrameName. [ah right, this is a .cpp file, so your MOZ_OVERRIDE script didn't hit this one]
I'll file a follow up fixing those.
Attachment #8378460 -
Flags: review?(dholbert) → review+
Comment 3•11 years ago
|
||
Filed bug 974562 on the missing MOZ_OVERRIDEs.
Assignee | ||
Comment 4•11 years ago
|
||
replaces all NS_IMETHOD from nsISVGChildFrame.h and child classes in layout/svg/
fixes indentations
windows tpbl went fine : https://tbpl.mozilla.org/?tree=Try&rev=444017aa0b05
Attachment #8378460 -
Attachment is obsolete: true
Attachment #8378601 -
Flags: review?(dholbert)
Updated•11 years ago
|
Attachment #8378601 -
Flags: review?(dholbert) → review+
Comment 5•11 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e6f445ceecd
Thanks for the patch!
Flags: in-testsuite-
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•