974178 - The Case of the Missing Marketplace Icon/back button

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Android: 4.4.2/Nightly 30.0a1(2014-02-18)

steps to reproduce:
1. Load marketplace-dev.allizom.org on Firefox mobile
2. Browse around to an app details page
3. Notice the Homepage icon

actual behavior:
Homepage icon disappears on you and it is not easy to get back to homepage.

Comment 1

[Mark Striemer [:mstriemer]]

I can only reproduce this partially. I see that when I go to a detail page that the marketplace icon disappears, but it is because the back arrow is supposed to show up and the back arrow eventually appears (albeit slowly sometimes). Are there any cases where this gets stuck without the icon ever appearing? I've seen several second delays but I haven't been able to get it to not appear.

Comment 2

[krupa raj[:krupa]]

When I navigate to the details page, if the back button is missing, it never loads for me. However, this does not happen all the time. Making this a P2.

Comment 3

[Mark Striemer [:mstriemer]]

I'm thinking that adding prefetching might be the best we can do here and with the spinner on install. I don't see anything in the ashes as to why these aren't showing up so hopefully it is just loading slowly and prefetching will fix it.

Comment 4

[Stuart Colville [:muffinresearch]]

If the image was there and it dissappears, have you tried forcing a repaint of the back button?

Historically we had some strange issues with disappearing images in b2g and the only "hacky" solution that worked was to poke the z-index of the element concerned which caused the layer to be repainted. E.g it would always bump the z-index up or down by one. You could also try using something simple like $foo.toggleClass('redraw') first too.

Comment 5

[Mark Striemer [:mstriemer]]

I managed to reproduce this once on -dev and checked the network panel of the dev tools and the request for the "active" back arrow had a grey icon which seems to indicate that it hasn't started yet. I clicked on it to get more info but I also put the phone down and then the image was requested. I'm wondering if switching to landscape caused it to load.

I tried setting the z-index with `$('.nav-back').css({'z-index': 100})` and then moved it up/down a few times and it never appeared. Toggling the `redraw` class a few times also did nothing (I'm not sure if that is a special class or an example but it's the one I tried).

No luck reproducing it again yet. I'm also wondering if it has something to do with that zoom we see when the keyboard closes since both times I've reproduced this it has been after creating/editing a review.

Comment 6

[Mark Striemer [:mstriemer]]

I have a few questions krupa since I can't reproduce this reliably.

1. Does the arrow ever disappear without tapping it?
2. Do you need to do anything special to make it disappear? (close keyboard, view a review, etc)
3. Does switching the device orientation make the arrow appear?
4. When it is missing does tapping on the page make it appear? (not a link just removing any focus that's set)

Comment 7

[Mark Striemer [:mstriemer]]

Andy reproduced this and it looks like there was a GC cycle right before the image went away. I'm hoping adding an Expires header will keep the image from being dropped https://dpaste.de/8i7W.

Comment 8

[Mark Striemer [:mstriemer]]

We now have expires headers on dev and stage, can you see if you can still reproduce this there please, krupa?

Comment 9

[krupa raj[:krupa]]

Attachment: missing back button

ashes: fcc23

Comment 10

[krupa raj[:krupa]]

I was able to see the missing back button issue on the search screen. Ashes and screenshot available in comment 9.

Comment 11

[Mark Striemer [:mstriemer]]

Looks like you also hit the GET requests failing bug at the same time. I have another test for you:

1. Get the back button to disappear.
2. Use the missing back button to go all the way back to the homepage.
    * Does the marketplace icon appear?
3. Click on an app you haven't been to.
    * Is the back button still missing?

Also how much memory does your phone have? Or what's the make/model, I should probably get one since it seems to be really good at reproducing bugs...

Comment 12

[krupa raj[:krupa]]

(In reply to Mark Striemer [:mstriemer] from comment #11)
> Looks like you also hit the GET requests failing bug at the same time. I
> have another test for you:
> 
> 1. Get the back button to disappear.
> 2. Use the missing back button to go all the way back to the homepage.
>     * Does the marketplace icon appear?
> 3. Click on an app you haven't been to.
>     * Is the back button still missing?
> 
> Also how much memory does your phone have? Or what's the make/model, I
> should probably get one since it seems to be really good at reproducing
> bugs...

Marketplace icon appears on the homepage but upon visiting a new details page, the back button is still missing.

I'm on an  Samsung Android phone 4.0.3 version. Device memory is around 2GB.

Comment 13

[krupa raj[:krupa]]

> 
> I'm on an  Samsung Android phone 4.0.3 version. Device memory is around 2GB.

s/an/a

Comment 14

[krupa raj[:krupa]]

Attachment: screenshot on details page

Comment 15

[Andy McKay]

We can't reproduce this anymore, see also bug 977704.

Comment 16

[krupa raj[:krupa]]

Attachment: screenshot of missing icon

Hit this issue a few seconds after andy closed the bug.

ashes: a99f0

nightly 30.0a1(03-13)

Comment 17

[krupa raj[:krupa]]

Attachment: screenshot 2 for reopening

Comment 18

[Mark Striemer [:mstriemer]]

Your latest ashes don't work for me but it looks like this bug appears alongside the GET requests fail bug. Can you reproduce and post some more ashes krupa?

This is the part that I see when GET requests are failing and it appears in your original ashes right after you search for :paid.

  [req] Opening pool
  [req] GETing https://marketplace.allizom.org/api/v1/apps/search/?cache=1&dev=android&device=mobile&full_q=%3Apaid&lang=en-US&premium_types=premium&q=&region=restofworld&vary=0
  [tracking] Tracking page view /search?q=%3Apaid
  [nav] Pushed state onto stack: /search?q=%3Apaid
->[req] Request failed: GET
  [req] Closing pool

Comment 19

[krupa raj[:krupa]]

Myk has my test device and when I get them back, I'll retest it.

Comment 20

[krupa raj[:krupa]]

I can confirm that this is a side-effect of GET requests failing.