974237 - Bookmarks panel is 1px right of its anchor's center and 1px too low

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Jose Fandos]

Attachment: Bookmark panel compared with "Bookmark this page" panel

This is a followup to bug 940379 comment 18.

In trunk the bookmark panel shows up with 1px difference from other panels alignment. See attached screenshot.

Comment 1

[Manish Goregaokar [:manishearth]]

Reproduced on Linux, though in my case there is some space between the panels and the toolbars for both panels.

Comment 2

[u428464]

And the bookmarks menu panel is also too much on the left compared to it anchor.

Comment 3

[:Gijs (out for now; he/him)]

This would be P4/P5 if it wasn't for comment #2 which is much more noticeable and jarring.

Comment 4

[Manish Goregaokar [:manishearth]]

Attachment: Animation of dropdowns on Linux

(In reply to :Gijs Kruitbosch from comment #3)
> This would be P4/P5 if it wasn't for comment #2 which is much more
> noticeable and jarring.

It's not jarring; both of them have *almost* equal spacing between themselves and the toolbar. It;s just that there is spacing, unlike the Mac screenshot.

Comment 5

[:Gijs (out for now; he/him)]

(In reply to Manish Goregaokar [:manishearth] from comment #4)
> Created attachment 8379102 [details]
> Animation of dropdowns on Linux
> 
> (In reply to :Gijs Kruitbosch from comment #3)
> > This would be P4/P5 if it wasn't for comment #2 which is much more
> > noticeable and jarring.
> 
> It's not jarring; both of them have *almost* equal spacing between
> themselves and the toolbar. It;s just that there is spacing, unlike the Mac
> screenshot.

I said comment #2. Which is about the fact that it's *horizontally* misaligned, ie too far to the left.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

The horizontal placement of this is pretty easy to fix, someone will just need to adjust the negative left/right margins of the bookmarks panel to get it in the right spot.

Comment 7

[:Gijs (out for now; he/him)]

This is a lot better now. Don't know when it got better, but I'll take it.

Comment 8

[Marco Bonardo [:mak]]

The star moved back into the address bar