974319 - Mock DOMRequest and get rid of some setTimeout() in unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #971546 +++

setTimeout() is proven to be lengthen and maybe unreliable for automation, we should replace them with Mock DOMRequest that is a little bit smarter.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With bug 971546 stuck in the bubble-tea branch in the coming weeks I cannot remove all setTimeout() DOMRequest usage without creating conflicts. Here is my WIP

https://github.com/timdream/gaia/tree/mock-dom-request

We could (A) land this first, create another bug to do the conversion after bubble-tea merges, or (B) we could keep the original scope of this bug and do it altogether.

I prefer (B)....

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/17507

So I fixed all the tests that rely on system/test/unit/mock_navigator_get_device_storage.js like what I intended to do when I was working on bug 971546.

storage_watcher_test.js is fixed and it now runs much faster.

An interesting thing I found is that bluetooth_transfer_test.js does not test any code patch that reaches the device storage API. I will file a bug to ask for a fix.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8395547 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/17507

r+ with nit

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/73ca686bf6019a152f9c3c0a81f9b19d27ad9ade

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8395547 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/17507

It seems that my input is not needed here anymore.