971546 - [System2] Instantiable Screenshot

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need screenshot.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/timdream/gaia/tree/system2-screenshot

WIP. The rewrite is quite simple, but writing unit tests is HARD.....

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#16442

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8378147 [details] [review]
mozilla-b2g:master PR#16442

So I managed to write unit test for this with a lot of setTimeout(). This is sad because the test would rely on the browser to actually invoke setTimeout'd functions, and the order of these setTimeout calls.

I will file follow-up bugs to convert the mock and tests to something without setTimeout by introducing a MockDOMRequest.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8378147 [details] [review]
mozilla-b2g:master PR#16442

r+ with nits(_started protection)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Follow up = bug 974319

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/16549

nit addressed, waiting for Travis-CI and going to merge this to bubble-tea.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

merged to bubble-tea:
https://github.com/mozilla-b2g/gaia/commit/1a78cae15870f02f743e3bd4f67b72b1ba96b5ea

Comment 8

[[e-mail]]

merged to master https://github.com/gasolin/gaia/commit/ec5be24bd877588f60f6c64715b894157a20c603

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reverted in https://github.com/mozilla-b2g/gaia/commit/60e9eb1aa68a27fa21e75264e52409aa5a2b4cc4 because something in this or one of the six other patches that the b2g bumper bot included in a single push to b2g-inbound broke gaia-ui tests on TBPL:

bumper bot's push's contents: https://hg.mozilla.org/integration/b2g-inbound/rev/0c2938cd910b
The gaia-ui failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=36421229&tree=B2g-Inbound


In the future, can we please not merge seven patches in the course of 5 minutes? It would make tracking down regressions much simpler if they were spaced several minutes apart each.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I created this

https://github.com/mozilla-b2g/gaia/pull/17376

To land the patch independently of bubble-tea.

Comment 11

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/c9770f0314c188b6a6c9b5b75b969ca488c7237b