Closed Bug 974427 Opened 6 years ago Closed 4 years ago

Generalize page_row_height dimension

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: lucasr, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java])

It's not used in more layouts that are not necessarily about a 'page'.
Assignee: lucasr.at.mozilla → nobody
Whiteboard: [mentor=lucasr][lang=java]
This isn't used in panel_article_item anymore, and if we make image items have dynamic heights as well (bug 974434), we can probably remove the fixed height rule from panel_image_item as well.

We can leave this open for now, but it probably won't be an issue anymore when bug 974434 is fixed.
Mentor: lucasr.at.mozilla
Whiteboard: [mentor=lucasr][lang=java] → [lang=java]
Margaret, would you like to mentor?
Flags: needinfo?(margaret.leibovic)
(In reply to Michael Comella (:mcomella) from comment #2)
> Margaret, would you like to mentor?

Sure. I think there's enough information here to get started.
Mentor: lucasr.at.mozilla → margaret.leibovic
Flags: needinfo?(margaret.leibovic)
Is this still valid? If not, let's close it.
Flags: needinfo?(liuche)
I don't see anything that should be combined into page_row_height, and the other usages of 64dp (at the moment) seem to be well organized and not actually related to page_row_height.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(liuche)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.