Closed Bug 974460 Opened 7 years ago Closed 7 years ago
Add translation icon to URL bar structure
We need to add a translation icon in the URL bar structure (together where the doorhanger icons go), which will be displayed together with the translation infobar when we offer a page translation. If the infobar is dismissed, it can be retrieved by clicking in this icon. Maybe it will be a dynamic addition (possibly through the doorhanger code), maybe it can be a direct addition in the xul structure (because i'm not sure if the doorhanger code will be very suitable here).
Assignee: nobody → sfranks
Status: NEW → ASSIGNED
Whiteboard: [translation] p=0 → [translation] p=2 s=it-30c-29a-28b.3
Whiteboard: [translation] p=2 s=it-30c-29a-28b.3 → [translation] p=2 s=it-30c-29a-28b.3 [qa+]
If the icon is expected to look the same on all OSes, then I would need a 16x16 icon, and the same @2x for retina mac screens (so a 32x32 version of the same icon). If you want to have OS-specific versions of the icon, then the files would be: 16x16 Windows 16x16 Windows aero (file used for Windows Vista and later) 16x16 Linux 16x16 Mac 32x32 Mac @2x for retina screens.
Whiteboard: [translation] p=2 s=it-30c-29a-28b.3 [qa+] → [translation] p=2 s=it-31c-30a-29b.1 [qa+]
Icons can be found in Bug 974521
Whiteboard: [translation] p=2 s=it-31c-30a-29b.1 [qa+] → [translation] p=2 s=it-31c-30a-29b.2 [qa+]
No longer blocks: fxdesktopbacklog
Attachment #8400769 - Flags: review?(felipc) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
I found a potential issue here using try-build from bug 974461 comment 7. A dotted square appears on the icon when retrieving the infobar. This happens only in Private Window on Windows 7, XP and 8.1 but not on Windows 8.1 on a Surface Pro 2 and always on Ubuntu. I did not encountered any issues on Mac OS X 10.9.2. I attached a .gif showing the potential issue. Should I log a bug on this?
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #6) > A dotted square appears on the icon when retrieving the infobar. [...] > Should I log a bug on this? Yes please, this is ugly we should fix it.
(In reply to Florian Quèze [:florian] [:flo] from comment #7) > (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #6) > > > A dotted square appears on the icon when retrieving the infobar. > [...] > > Should I log a bug on this? > > Yes please, this is ugly we should fix it. Logged bug 993959 on that. Also verified as fixed this issue on Windows XP 32bit, Windows 7 64bit, Windows 8.1 64bit, Windows 8.1 64bit on Surface Pro, Ubuntu 13.10 32bit and Mac OS X 10.9.2 using try build from bug 974461 comment 7.
Status: RESOLVED → VERIFIED
Whiteboard: [translation] p=2 s=it-31c-30a-29b.2 [qa+] → [translation] p=2 s=it-31c-30a-29b.2 [qa!]
Mass move of translation bugs to the new Translation component.
Component: Location Bar → Translation
You need to log in before you can comment on or make changes to this bug.