Closed
Bug 974460
Opened 10 years ago
Closed 10 years ago
Add translation icon to URL bar structure
Categories
(Firefox :: Translations, defect)
Firefox
Translations
Tracking
()
VERIFIED
FIXED
Firefox 31
People
(Reporter: Felipe, Assigned: florian)
References
Details
(Whiteboard: [translation] p=2 s=it-31c-30a-29b.2 [qa!])
Attachments
(2 files)
16.38 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
524.33 KB,
image/gif
|
Details |
We need to add a translation icon in the URL bar structure (together where the doorhanger icons go), which will be displayed together with the translation infobar when we offer a page translation. If the infobar is dismissed, it can be retrieved by clicking in this icon. Maybe it will be a dynamic addition (possibly through the doorhanger code), maybe it can be a direct addition in the xul structure (because i'm not sure if the doorhanger code will be very suitable here).
Updated•10 years ago
|
Component: General → Location Bar
Updated•10 years ago
|
Whiteboard: [translation] p=0
Updated•10 years ago
|
Assignee: nobody → sfranks
Status: NEW → ASSIGNED
Whiteboard: [translation] p=0 → [translation] p=2 s=it-30c-29a-28b.3
Updated•10 years ago
|
Whiteboard: [translation] p=2 s=it-30c-29a-28b.3 → [translation] p=2 s=it-30c-29a-28b.3 [qa+]
Updated•10 years ago
|
QA Contact: bogdan.maris
Assignee | ||
Comment 1•10 years ago
|
||
If the icon is expected to look the same on all OSes, then I would need a 16x16 icon, and the same @2x for retina mac screens (so a 32x32 version of the same icon). If you want to have OS-specific versions of the icon, then the files would be: 16x16 Windows 16x16 Windows aero (file used for Windows Vista and later) 16x16 Linux 16x16 Mac 32x32 Mac @2x for retina screens.
Updated•10 years ago
|
Whiteboard: [translation] p=2 s=it-30c-29a-28b.3 [qa+] → [translation] p=2 s=it-31c-30a-29b.1 [qa+]
Comment 2•10 years ago
|
||
Icons can be found in Bug 974521
Updated•10 years ago
|
Assignee: sfranks → florian
Updated•10 years ago
|
Whiteboard: [translation] p=2 s=it-31c-30a-29b.1 [qa+] → [translation] p=2 s=it-31c-30a-29b.2 [qa+]
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8400769 -
Flags: review?(felipc)
Updated•10 years ago
|
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Reporter | ||
Updated•10 years ago
|
Attachment #8400769 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4791c51639d4
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4791c51639d4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Comment 6•10 years ago
|
||
I found a potential issue here using try-build from bug 974461 comment 7. A dotted square appears on the icon when retrieving the infobar. This happens only in Private Window on Windows 7, XP and 8.1 but not on Windows 8.1 on a Surface Pro 2 and always on Ubuntu. I did not encountered any issues on Mac OS X 10.9.2. I attached a .gif showing the potential issue. Should I log a bug on this?
Flags: needinfo?(florian)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #6) > A dotted square appears on the icon when retrieving the infobar. [...] > Should I log a bug on this? Yes please, this is ugly we should fix it.
Flags: needinfo?(florian)
Comment 8•10 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #7) > (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #6) > > > A dotted square appears on the icon when retrieving the infobar. > [...] > > Should I log a bug on this? > > Yes please, this is ugly we should fix it. Logged bug 993959 on that. Also verified as fixed this issue on Windows XP 32bit, Windows 7 64bit, Windows 8.1 64bit, Windows 8.1 64bit on Surface Pro, Ubuntu 13.10 32bit and Mac OS X 10.9.2 using try build from bug 974461 comment 7.
Status: RESOLVED → VERIFIED
Whiteboard: [translation] p=2 s=it-31c-30a-29b.2 [qa+] → [translation] p=2 s=it-31c-30a-29b.2 [qa!]
Assignee | ||
Comment 9•10 years ago
|
||
Mass move of translation bugs to the new Translation component.
Component: Location Bar → Translation
You need to log in
before you can comment on or make changes to this bug.
Description
•