974496 - Enable sync promo banner

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Now that bug 974195 is done, we could enable the sync promo banner. However, we probably want to wait for bug 961523 before we do this to avoid annoying users.

Comment 1

[:Margaret Leibovic]

Attachment: patch

Here's a patch. I'll wait until we get a product call to flip this switch before getting review and landing it.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8379942 [details] [diff] [review]
patch

Just need a rubber stamp here :)

I'll wait until bug 975423 is reviewed and land these together.

Comment 3

[:Margaret Leibovic]

I realized we'll want to keep this disabled for tests, so that we don't have an issue like bug 965358.

I set this pref to false in the default testing profile and I'm giving this a try push:
https://tbpl.mozilla.org/?tree=Try&rev=0b9a8698583b

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0d65391f3ef0

I also wonder what impact this will have on eideticker...

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0d65391f3ef0

Comment 6

[:Margaret Leibovic]

Comment on attachment 8379942 [details] [diff] [review]
patch

Note to sheriffs: I'm requesting approval now, but I don't want to uplift this until the follow-up bug fixes have been uplifted.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): sync promo banner (for new sync)
User impact if declined: new sync won't be promoted
Testing completed (on m-c, etc.): landed on m-c 2/23, working on addressing follow-ups
Risk to taking this patch (and alternatives if risky): the main risk is that this banner will appear when we don't intend for it to appear, or that its appearance will be slightly wrong. we're working on addressing the follow-up bugs that have come up on m-c
String or IDL/UUID changes made by this patch: none

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Margaret, if I understand correctly, you want us to approve this patch only when bug 975469 is fixed?
Could you n-i us once it is done? thanks

Comment 8

[:Margaret Leibovic]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Margaret, if I understand correctly, you want us to approve this patch only
> when bug 975469 is fixed?
> Could you n-i us once it is done? thanks

Sorry I wasn't very clear. I just want to make sure we uplift most of the banner-related bugs (those bugs that block bug 862801 as well as the fixed ones that block this one) before we flip the switch to turn on this promo banner on aurora.

I'm working on uplifting the current set of approved bugs right now, and after that happens, I think I would feel confident enabling this promo banner on aurora. However, I think QA should verify those bugs on aurora first.

So, yes, I can n-i you once all that is done :)

Comment 9

[:Margaret Leibovic]

Update here: I just uplifted a majority of the home banner patches to aurora, so once QA verifies that those issues are indeed fixed on aurora, I think it would be safe to go ahead and enable the sync promo banner.

Deb, do you think we should go ahead and enable the sync promo banner on aurora? This would also mean that it would be automatically enabled on beta once 29 merges to beta in a few weeks.

Comment 10

[Deb Richardson [:dria] (plz NEEDINFO)]

Margaret: assuming we'll be able to turn it off in the very very remote chance we need to, then enabling it on Aurora is fine.  The more sync testing we get, the better.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8379942 [details] [diff] [review]
patch

Margaret, thanks! Approving then!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/25e8e343ef75