Closed Bug 974878 Opened 6 years ago Closed 5 years ago

[MMS]Create new contact/ add to exist contact with email address

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ta-matsuura, Assigned: na-matsumoto)

References

Details

Attachments

(2 files)

[User story]
When user tap email address of at the top of chat screen, create new contact or add to exist contact.
This is same feature as phone number case.
Blocks: 974333
Assignee: nobody → na-matsumoto
Group: kddi-confidential
Summary: [MADAI][MMS]Create new contact/ add to exist contact with email address → [MMS]Create new contact/ add to exist contact with email address
Adding a depends-on bug 984715, which is a case we should consider when implementing "add to contact".
Depends on: 984715
I will PR after finishing Bug 974867.
Flags: needinfo?(wchang)
Thanks Naoya!
Flags: needinfo?(wchang)
Target Milestone: --- → 2.0 S4 (20june)
Depends on: 974867
Blocks: 982029
Target Milestone: 2.0 S4 (20june) → ---
Hi, Julien and Steve.
I PR Attachment 8450888 [details].
Please review it.
Does this patch blocks, or needs bug 982029 ? It seems to me we need bug 982029 so that "promptContact" works as expected?
I had a first look and this looks fine but I'm too tired right now to properly review. I'll do it on monday.
Comment on attachment 8450888 [details] [review]
Create new contact/ add to exist contact with email address patch on github

r=me

please add "r=julien" in your commit log (using "git commit --amend"), then push to your pull request, and then add "checkin-needed" in the "keywords" section in the bug.

Thanks !
Attachment #8450888 - Flags: review?(schung)
Attachment #8450888 - Flags: review?(felash)
Attachment #8450888 - Flags: review+
Attachment #8452878 - Flags: review+
Attachment #8452878 - Flags: review+ → review?(felash)
Hi, Julien. Thanks for your review.
I rebased and added "r=julien" in my commit log.
Please review Attachment 8452878 [details].
Comment on attachment 8452878 [details] [review]
Create new contact/ add to exist contact with email address patch on github

It was already r+ so you don't need to ask review again unless you do unagreed changes :)

landed in master: ba9da60d7b2ae227f11103ddabc760fbd5e4f8c8
Attachment #8452878 - Flags: review?(felash) → review+
Flags: needinfo?(felash)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
[Blocking Requested - why for this release]:
Nominating this for v2.0, as desired on a 2.0 product.
blocking-b2g: --- → 2.0?
ni? Wayne on how we should be treating these late requests for 2.0.  Wayne, can you drive this bug offline?
Flags: needinfo?(wchang)
From a thread with Wayne and Lucas I can confirm that it is too late to accept this new feature work in 2.0. If this work is required for partner product, it will need to be cherry picked off of the 2.1 branch.
blocking-b2g: 2.0? → ---
Flags: needinfo?(wchang)
set partner flag requested by partner.
Group: kddi-confidential
Group: kddi-confidential
You need to log in before you can comment on or make changes to this bug.