974878 - [MMS]Create new contact/ add to exist contact with email address

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Taichi Matsuura]

[User story]
When user tap email address of at the top of chat screen, create new contact or add to exist contact.
This is same feature as phone number case.

Comment 1

[Wayne Chang [:wchang]]

Adding a depends-on bug 984715, which is a case we should consider when implementing "add to contact".

Comment 2

[Naoya Matsumoto]

I will PR after finishing Bug 974867.

Comment 3

[Wayne Chang [:wchang]]

Thanks Naoya!

Comment 4

[Naoya Matsumoto]

Attachment: Create new contact/ add to exist contact with email address patch on github

Comment 5

[Naoya Matsumoto]

Hi, Julien and Steve.
I PR Attachment 8450888 [details].
Please review it.

Comment 6

[Julien Wajsberg [:julienw]]

Does this patch blocks, or needs bug 982029 ? It seems to me we need bug 982029 so that "promptContact" works as expected?

Comment 7

[Julien Wajsberg [:julienw]]

I had a first look and this looks fine but I'm too tired right now to properly review. I'll do it on monday.

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8450888 [details] [review]
Create new contact/ add to exist contact with email address patch on github

r=me

please add "r=julien" in your commit log (using "git commit --amend"), then push to your pull request, and then add "checkin-needed" in the "keywords" section in the bug.

Thanks !

Comment 9

[Naoya Matsumoto]

Attachment: Create new contact/ add to exist contact with email address patch on github

Comment 10

[Naoya Matsumoto]

Hi, Julien. Thanks for your review.
I rebased and added "r=julien" in my commit log.
Please review Attachment 8452878 [details].

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8452878 [details] [review]
Create new contact/ add to exist contact with email address patch on github

It was already r+ so you don't need to ask review again unless you do unagreed changes :)

landed in master: ba9da60d7b2ae227f11103ddabc760fbd5e4f8c8

Comment 12

[at-kitamura]

[Blocking Requested - why for this release]:
Nominating this for v2.0, as desired on a 2.0 product.

Comment 13

[Tony Chung [:tchung]]

ni? Wayne on how we should be treating these late requests for 2.0.  Wayne, can you drive this bug offline?

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

From a thread with Wayne and Lucas I can confirm that it is too late to accept this new feature work in 2.0. If this work is required for partner product, it will need to be cherry picked off of the 2.1 branch.

Comment 15

[Makoto Kato [:m_kato]]

set partner flag requested by partner.