Closed Bug 974942 Opened 10 years ago Closed 10 years ago

Don't share strings/reuse "Terms of service" and "Privacy notice" (subject vs. object)

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Version:
Firefox 30
Platform:
All
Android
Type:
defect

Tracking

(firefox29 wontfix, firefox30 fixed, fennec30+)

Status:
RESOLVED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
fennec 30+ ---

People

(Reporter: aryx, Assigned: nalexander)

References

Details

The strings
<!ENTITY fxaccount_policy_linktos 'Terms of Service'>
<!ENTITY fxaccount_policy_linkprivacy 'Privacy Notice'>
from mobile/android/base/locales/en-US/sync_strings.dtd

are used as stand-alone links in the Sync status page and as inline links:
<!-- Localization note: &formatS1; is fxaccount_policy_linktos, &formatS2; is fxaccount_policy_linkprivacy, both hyperlinked. -->
<!ENTITY fxaccount_create_account_policy_text 'By proceeding, I agree to the &formatS1; and &formatS2; of Firefox online services.'>

Because some languages decline objects, this can cause trouble and the strings shouldn't be shared.
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
aryx: thanks!  I learn something every day.
Anything we can/should do for this in 29? I presume no, but worth asking.
tracking-fennec: --- → 30+
status-firefox29: --- → affected
status-firefox30: --- → affected
Hardware: ARM → All
Axel, should any action be taken on Aurora about this?
Flags: needinfo?(l10n)
Note that this is coincidentally the string we want to change on Aurora for Bug 974015.
I don't think we should take this for aurora.
Flags: needinfo?(l10n)
status-firefox29: affected → wontfix
Version: Firefox 29 → Firefox 30
Assignee: nobody → nalexander
Blocks: 972888
Priority: -- → P1
https://hg.mozilla.org/integration/fx-team/rev/503ab98c04c8
Status: NEW → ASSIGNED
status-firefox30: affected → fixed
Target Milestone: --- → Firefox 30
https://hg.mozilla.org/mozilla-central/rev/503ab98c04c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.