975192 - [B2G][Camera] No option to cancel out of taking a new photo for a contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Rachel Pribble [:rpribble]]

Description:
After navigating to the camera through the edit contact option to take a new contact photo, no option to cancel or back out is shown other than tapping the home button. User is unable to back out and return to the contact details.

Repro Steps:
1) Updated buri to BuildID: 20140220040203
2) Tap contacts icon
3) Select a contact and tap it
4) Tap the edit contact button in the upper right corner
5) Tap the contact photo to change it
6) Select the camera option
7) Observe lack of X or cancel button

Actual:
No option to cancel out of taking a new photo for a contact and return to contact details.

Expected:
User never blocked from performing an action.

Environmental Variables:
Device: buri v14 moz
BuildID: 20140220040203
Gaia: 6e71ab4da1b08586ea0c758edb7aa199ee34cd2f
Gecko: 660b62608951
Version: 30.0a1
RIL Version:
Firmware Version: Settings > Device Information > More Information > Firmware revision (example.D30008m)

Notes:

Repro frequency: 100%

Comment 1

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri
BuildID: 20140215095648
Gaia: 8ac5dc6b76709e742cb923c58d1f4b415b3e08fb
Gecko: 9394396013a8
Version: 30.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri 
BuildID: 20140215100248
Gaia: f75b9dac351c0676f0fc696fa36330933985ed36
Gecko: 4ebfb26de52c
Version: 30.0a1
Base Image: V1.2-device.cfg

Last Working Gaia/First Broken Gecko: Issue does NOT reproduce
Gaia: 8ac5dc6b76709e742cb923c58d1f4b415b3e08fb
Gecko: 4ebfb26de52c

First Broken Gaia/Last Working Gecko: Issue DOES reproduce
Gaia: f75b9dac351c0676f0fc696fa36330933985ed36
Gecko: 9394396013a8

Comment 2

[David Flanagan [:djf]]

Do we have UX specs and new visuals for this?  In the 1.3 camera, it is just an X in the lower left when we're doing a pick activity.

Comment 3

[Wilson Page [:wilsonpage]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/cf244e06489863fdd7dd5adef91fee28f0c8b243

Comment 4

[Wilson Page [:wilsonpage]]

IGNORE LAST COMMENT ^^^

Comment 5

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 6

[Wilson Page [:wilsonpage]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/d62991e8b97d382f39b44856ea996fb1bb90a459

Comment 7

[David Flanagan [:djf]]

Do you have a followup bug filed to convert the cancel button to your icon font?

Comment 8

[Wilson Page [:wilsonpage]]

I'm not sure I have seen a spec for the cancel button in the latest camera visuals. I don't think it's worth implementing for 1.3, but will definitely be vector in the 1.4/1.5 refresh.

Amy, do you have visuals for this 'cancel pick' scenario?

Comment 9

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #8)
> I'm not sure I have seen a spec for the cancel button in the latest camera
> visuals. I don't think it's worth implementing for 1.3, but will definitely
> be vector in the 1.4/1.5 refresh.
> 
> Amy, do you have visuals for this 'cancel pick' scenario?

Hi Wilson, 

I haven't seen any UX spec for this function so no visuals have been created. I'm going to needinfo Rob.

Comment 10

[Rob MacDonald [:robmac]]

Hi everyone...

This is definitely a gap in the 1.4/1.5 spec. I'll put something together quickly and discuss it with Amy tomorrow morning pacific time. I'll flag Amy as a heads up. :)

- Rob

Comment 11

[Amy Lee [:amylee] UX]

Attachment: CSS_Pixels_ImageCapture_Contacts.png

Hi Wilson, 
Here is the spec for canceling image capture from contacts.

Comment 12

[Amy Lee [:amylee] UX]

Attachment: imagecapture_cancel.svg

Cancel icon