982071 - Unusable Camera app when triggered from pick activity for file upload

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[:gerard-majax]

Attachment: 2MHHbRc.png

See the attached screenshot: Camera app does not start properly.

STR:
 0. Open browser
 1. Go to http://m.imgur.com/upload
 2. Tap "Device", then select Photo in the activity chooser

Expected:
 Camera app starts correctly

Actual:
 Confere screenshot. Camera app not usable.

This is reproducing on both Camera app from the current master and from camera-new-features branch.

Comment 1

[:gerard-majax]

logcat shows:
E/GeckoConsole( 1275): [JavaScript Error: "TypeError: setting is undefined" {file: "app://camera.gaiamobile.org/js/main.js" line: 4292}]

Comment 2

[Hema Koka [:hema]]

Blocking just by going with broken functionality criteria

Comment 3

[Matthew Vaughan]

The following regression window was found using b2g-inbound builds:

- Last Working -
Device: Buri ENG v1.4 MOZ RIL
BuildID: 20140225203818
Gaia: 6003c319780f49871dbe91ce5af32f5fc8ec06d9
Gecko: 4fe213a22c59
Version: 30.0a1
Firmware Version: V1.2-device.cfg

- First Broken -
Device: Buri ENG v1.4 MOZ RIL
BuildID: 20140225213719
Gaia: d62991e8b97d382f39b44856ea996fb1bb90a459
Gecko: 02217076e7d5
Version: 30.0a1
Firmware Version: V1.2-device.cfg

**This looks to be a gaia issue**
Push Log: https://github.com/mozilla-b2g/gaia/compare/6003c319780f49871dbe91ce5af32f5fc8ec06d9...d62991e8b97d382f39b44856ea996fb1bb90a459

Comment 4

[Jason Smith [:jsmith]]

This is a regression from bug 975192.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Setting NEEDINFO for Wilson:

Wilson, the error is happening on the following line:

https://github.com/mozilla-b2g/gaia/blob/camera-new-features/apps/camera/js/lib/setting-alias.js#L56

E/GeckoConsole(  914): [JavaScript Error: "TypeError: setting is undefined" {file: "app://camera.gaiamobile.org/js/main.js" line: 4703}]

This seems to be an issue with the SettingAlias model and I have some questions as to the flow of execution with it. Ping me when you're online so I can discuss with you. Thanks!

Comment 6

[Hema Koka [:hema]]

Wilson is out on 3/19 and 3/21. Wilson, please take a look when you are back tomorrow.

Thanks
Hema

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: pull-request (camera-new-features)

Comment 8

[Justin D'Arcangelo [:justindarc]]

Landed on camera-new-features:

https://github.com/mozilla-b2g/gaia/commit/d8fd55a7f1ef63ff24e3374abb11ea06849be07d

Comment 9

[Jason Smith [:jsmith]]

This needs to land on the main Gaia branch before this gets marked fixed. Otherwise, someone will just open a new bug for this.

Comment 10

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Diego: We already landed this on camera-new-features, we need to also land on master.

Comment 11

[Diego Marcos [:dmarcos]]

Yes. This will land on master once we merge camera-new-features. Partner requirement

Comment 12

[Jason Smith [:jsmith]]

(In reply to Diego Marcos [:dmarcos] from comment #11)
> Yes. This will land on master once we merge camera-new-features. Partner
> requirement

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=984730#c19.

Comment 13

[Diego Marcos [:dmarcos]]

Justin. This is 1.4 blocker. Your PR should go on top of v1.4 branch instead of master

Comment 14

[Diego Marcos [:dmarcos]]

Can we merge this with the rest of camera-new-features branch?

Comment 15

[Justin D'Arcangelo [:justindarc]]

Sorry, I can re-submit the PR, but let's wait to see what the plan is for landing camera-new-features today first.

Comment 16

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 17

[sarsenyev]

The bug is no longer reproduces on 1.4 and master build
Camera app starts and taking pictures correctly

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140410000201
Gaia: 9b2da43dfee3792cd311ae55f0b06272313208f0
Gecko: 9d9ead7d6afa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140410040201
Gaia: 9d0b1bdf746823a94b13e6574c1d8304dc584763
Gecko: 690c810c8e3e
Version: 31.0a1
Firmware Version: v1.2-device.cfg