Closed Bug 975249 Opened 7 years ago Closed 6 years ago

[marionette-helper] add fillInputField method

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gduan, Assigned: gduan)

References

Details

Attachments

(2 files, 1 obsolete file)

There are some use cases that we may need to feed text and trigger input event when testing with marionette.
Assignee: nobody → gduan
No longer blocks: 968686
Attached file PR to master (obsolete) —
Hi Evan,
could you kindly help me to review this patch?
Now , we can tap on input col and trigger input event.
Thanks.
Attachment #8379529 - Flags: review?(evanxd)
Comment on attachment 8379529 [details] [review]
PR to master

Hi George,

I left comments for your patch.
Please set r? after update the patch.

Thanks. :)
Attachment #8379529 - Flags: review?(evanxd)
Comment on attachment 8379529 [details] [review]
PR to master

Updated. Please kindly check again, thanks!
Attachment #8379529 - Flags: review?(evanxd)
Comment on attachment 8379529 [details] [review]
PR to master

Hi George,

I left comments for your patch.
Please update for that, then set r? again.
Thanks.

BTW, have a nice trip. :)
Attachment #8379529 - Flags: review?(evanxd)
Comment on attachment 8386576 [details] [review]
PR to master

Hi Evan ,
could you help me to review this patch?Thanks.
Attachment #8386576 - Flags: review?(evanxd)
Attachment #8386576 - Flags: review?(evanxd) → review+
Hi George,

r+!
Really nice job.
I learned a lot.
https://github.com/cctuan/marionette-helper/commit/c369e126392ceac6ce4c0559a6dff5bc8b799913
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: [marionette-helper] add tapInput method → [marionette-helper] add fillInputField method
Comment on attachment 8386677 [details] [review]
PR to gaia-node-modules

Hi Evan , 
I sent a pr to gaia-node-modules here. Please let me know if it's necessary to open another bug for it. Thanks.
Attachment #8386677 - Flags: review?(evanxd)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8386677 [details] [review]
PR to gaia-node-modules

Hi George,

You could just update the module without review.
Please follow the steps[1] to update.
Thanks.

[1] https://github.com/mozilla-b2g/gaia-node-modules/#updating-gaia-node-modules
Attachment #8386677 - Flags: review?(evanxd)
It was already merged.
https://github.com/mozilla-b2g/gaia-node-modules/commit/176df21cf9030444980177cd91b7029812368d1b
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.