Closed
Bug 975249
Opened 10 years ago
Closed 9 years ago
[marionette-helper] add fillInputField method
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gduan, Assigned: gduan)
References
Details
Attachments
(2 files, 1 obsolete file)
There are some use cases that we may need to feed text and trigger input event when testing with marionette.
Assignee | ||
Comment 1•10 years ago
|
||
Hi Evan, could you kindly help me to review this patch? Now , we can tap on input col and trigger input event. Thanks.
Attachment #8379529 -
Flags: review?(evanxd)
Comment 2•10 years ago
|
||
Comment on attachment 8379529 [details] [review] PR to master Hi George, I left comments for your patch. Please set r? after update the patch. Thanks. :)
Attachment #8379529 -
Flags: review?(evanxd)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8379529 [details] [review] PR to master Updated. Please kindly check again, thanks!
Attachment #8379529 -
Flags: review?(evanxd)
Comment 4•10 years ago
|
||
Comment on attachment 8379529 [details] [review] PR to master Hi George, I left comments for your patch. Please update for that, then set r? again. Thanks. BTW, have a nice trip. :)
Attachment #8379529 -
Flags: review?(evanxd)
Assignee | ||
Comment 5•10 years ago
|
||
Revert the commit: https://github.com/mozilla-b2g/marionette-helper/commit/38af34b1e20f33980ceeb9a954c50b698d8e043d
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8379529 [details] [review] PR to master >https://github.com/mozilla-b2g/marionette-helper/pull/20
Attachment #8379529 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8386576 [details] [review] PR to master Hi Evan , could you help me to review this patch?Thanks.
Attachment #8386576 -
Flags: review?(evanxd)
Updated•10 years ago
|
Attachment #8386576 -
Flags: review?(evanxd) → review+
Comment 9•10 years ago
|
||
Hi George, r+! Really nice job. I learned a lot.
Comment 10•10 years ago
|
||
https://github.com/cctuan/marionette-helper/commit/c369e126392ceac6ce4c0559a6dff5bc8b799913
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Summary: [marionette-helper] add tapInput method → [marionette-helper] add fillInputField method
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8386677 [details] [review] PR to gaia-node-modules Hi Evan , I sent a pr to gaia-node-modules here. Please let me know if it's necessary to open another bug for it. Thanks.
Attachment #8386677 -
Flags: review?(evanxd)
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 13•10 years ago
|
||
Comment on attachment 8386677 [details] [review] PR to gaia-node-modules Hi George, You could just update the module without review. Please follow the steps[1] to update. Thanks. [1] https://github.com/mozilla-b2g/gaia-node-modules/#updating-gaia-node-modules
Attachment #8386677 -
Flags: review?(evanxd)
Assignee | ||
Comment 14•9 years ago
|
||
It was already merged. https://github.com/mozilla-b2g/gaia-node-modules/commit/176df21cf9030444980177cd91b7029812368d1b
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•