[settings] add marionette test for Date & Time panel

NEW
Unassigned

Status

Firefox OS
Gaia::Settings
4 years ago
2 years ago

People

(Reporter: gasolin, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
1.4 S2 (28feb)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [ft:system-platform])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Overview Description:

Add marionette test for Date & Time panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for Date & Time panel


Expected Results:

Write that integration test and make test pass

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.
(Reporter)

Updated

4 years ago
Blocks: 969265
(Reporter)

Updated

4 years ago
No longer blocks: 956210
Assignee: nobody → gduan

Comment 1

4 years ago
Notice:
There is no automatic item for changing the date and time on b2g desktop-client, so please make sure the below test code can run on device in the future.

Test case spec for the Date & Time panel:

Change the "Region" item.
>> Make sure the "City" item render correctly.

Test case: Change the "Region" and "City" item.
>> Make sure the mozSettings value is correct.

Test case: Change the "Date" and "Time" item.
>> Make sure the mozSettings value is correct.

If have any question, please discuss here.
Thanks. :)
(Reporter)

Updated

4 years ago
Blocks: 973441

Updated

4 years ago
Whiteboard: [ft:system-platform]
Target Milestone: --- → 1.4 S2 (28feb)
Created attachment 8378779 [details] [review]
PR to master

Hi Evan,
would you mind to recommend how to mock |mozTime| of navigator?
This api doesn't work on b2g-desktop , so I'd like to mock it and check if the function really has tried to modify its value.

I already tried injecting a mock file, which is just like what email app did, but it doesn't work, it always return me {set: null} when I execute console.log.


Please kindly advise.
Thanks.
Flags: needinfo?(evanxd)

Comment 3

4 years ago
Hi George,

You should return
```
__exposedProps__: {
  get: 'r',
  set: 'r'
}
```
in the `__defineGetter__`.

Please refer to https://github.com/evanxd/gaia/commit/e9b6f7c780e502ebac740e44a9da2583bdf89e84.

Thanks.
Flags: needinfo?(evanxd)
Depends on: 975249
No longer depends on: 975249
Depends on: 975249
Depends on: 980254
Depends on: 985112
Status: NEW → ASSIGNED
(Reporter)

Comment 4

4 years ago
move out from 1.4
Blocks: 956210
No longer blocks: 969265

Updated

4 years ago
feature-b2g: --- → 2.0

Updated

4 years ago
feature-b2g: 2.0 → ---
(Reporter)

Updated

4 years ago
Blocks: 969264
(Reporter)

Updated

4 years ago
No longer blocks: 956210
(Reporter)

Updated

3 years ago
Blocks: 1023735
Assignee: georgeiscoming → nobody
Status: ASSIGNED → NEW
(Reporter)

Comment 5

2 years ago
need some work to land it
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.