975265 - [Settings] Need to add LTE options in the network type selector

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

As we are going to support LTE, we need LTE related options in the network type selector.

Comment 1

[Anshul]

Since the Gecko bug is now resolved, we would need support for this bug to let user select LTE network mode from the settings. Requesting for 1.4?

Comment 2

[Sandip Kamat]

PM Triage: 1.4+

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/17067

Jose, could you help take a look at this patch? As the mapping is getting more complex, I move the logic to a separate module. It still utilizes the same function in utils.js but the function is supported by the new module. I think this is better for introducing AMD afterward.

The patch is almost done except for some strings waiting for feedback from the UX designer (i.e. null in the mapping).

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #3)
> Created attachment 8389093 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/17067
> 
> Jose, could you help take a look at this patch? As the mapping is getting
> more complex, I move the logic to a separate module. It still utilizes the
> same function in utils.js but the function is supported by the new module. I
> think this is better for introducing AMD afterward.

The PR disappeared from the bug but I'd been able to take a look at it through the PR URL.

The work LGTM, thanks Arthur.

I'm requesting at you ni? just for letting you know about it.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, Jose.

I am able to see the attachment(https://bugzilla.mozilla.org/attachment.cgi?id=8389093&action=edit). It seems a bug of bugzilla. Are you able to grant it via the link?

Comment 6

[Ken Chang[:kenkai]]

(In reply to Arthur Chen [:arthurcc] from comment #5)
> Thanks, Jose.
> 
> I am able to see the
> attachment(https://bugzilla.mozilla.org/attachment.
> cgi?id=8389093&action=edit). It seems a bug of bugzilla. Are you able to
> grant it via the link?

Hi Arthur,
  Please check bug 952026. UX team has defined options for network types.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8389093 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17067

Jose, I updated the strings on the basis of UX desiger's suggestion. (Not as what Ken suggested as they are for netowrk technologies) Could you help review the patch? Thanks!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8389093 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17067

LGTM, r=me with the comments I left in the PR addressed.

Thanks for the work Arthur and specially for the test you added for it.

I tested this patch on peak and everything seems to work. Sadly I do not have a LTE device so I'm not able to see how the network type select behaves when lte technology is supported.

Comment 9

[Inder]

Anshul, can you please have someone try out this patch and provide feedback here if it's working on QRD devices or not.

Comment 10

[Anshul]

Chris, could you please pull in the patch and confirm if it is working with LTE?

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #8)
> Comment on attachment 8389093 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/17067
> 
> LGTM, r=me with the comments I left in the PR addressed.
> 
> Thanks for the work Arthur and specially for the test you added for it.
> 
> I tested this patch on peak and everything seems to work. Sadly I do not
> have a LTE device so I'm not able to see how the network type select behaves
> when lte technology is supported.

Thanks for reviewing! nis addressed. Waiting for the test results.

Comment 12

[Anshul]

Tested the patch and the network modes are getting set to LTE as expected. I couldn't test the LTE data call itself but I think that is unnecessary for this path to move forward.

Comment 13

[Chris]

Tested this patch and an LTE data call connected was successfully established on ATT.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 27c9ed6413d56e9cb57426f93dc16b7df4878f83

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v1.4: 5c78ffabbadcd25c64493ce2d611019c846e84c4