952026 - [B2G] [RIL] [User story] Single Variant: Set commercial name used for a specific network mode technology

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sandip Kamat]

As I user I should be able to change the Network mode settings for various network modes(e.g. Selection of Global, LTE/CDMA, GSM/UMTS). Exact modes will be specified by operator partner)

Comment 1

[Ken Chang[:kenkai]]

Need change in gecko and Gecko.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

1.4 user story supposedly needs to be complete before Sprint3.
Will communicate with team to reconfirm target milestone.

Comment 3

[Ken Chang[:kenkai]]

This is a 1.4+ bug.

Comment 4

[Ken Chang[:kenkai]]

Here are some questions for UX.
1. Do we need to have a signal bar for LTE?
2. What is the name of item for selection LTE network?(4G or LTE)

Comment 5

[Beatriz Rodríguez [:brg]]

(In reply to Ken Chang[:ken] from comment #4)
> Here are some questions for UX.
> 2. What is the name of item for selection LTE network?(4G or LTE)
Thats a good question and different operators are using a different commercial name for this technology so there is a requirement to use the commercial name 4G or LTE accordingly to the carrier(mcc/mnc). This feature is covered by bug 923449. The requirement is to use the same name in all the device menus.

Comment 6

[Carmen Jimenez Cabezas]

Bug 923449 introduces a new settings (operatorResources.data.icon) that holds the operator specify value
for the text which is shown under Cellular & Data related with the data network type (2G, 3G, 4G,...).
That settings should be used in this bug also so the same value is shown at both places

Comment 7

[Carmen Jimenez Cabezas]

The string values for the select at settings > cellular & Data > Network type will be hold on the new setting that I can add to the previously mentioned bug 923449 with the name operatorResources.data.types (If you prefer a different name just tell me and I will change it)

Comment 8

[Carmen Jimenez Cabezas]

Bug 969642 adds the ability to read the value from the setting (customized per operator) and changes the value shown under Cellular & Data in the Settings menu

Comment 9

[GoodMike]

In respond to comment 2

1. Do we need to have a signal bar for LTE? UX- Yes, we do. Just like what we have for 2G and 3G. 
2. What is the name of item for selection LTE network?(4G or LTE) UX- 4G LTE ?

And if we are going with dynamic expression, the signal bar/icon design should be just one but not two sets.

Comment 10

[Beatriz Rodríguez [:brg]]

(In reply to GoodMike from comment #9)
> In respond to comment 2
> 2. What is the name of item for selection LTE network?(4G or LTE) UX- 4G LTE
> ?
> 
I want to avoid any confusion as this is a carrier requirement.
GoodMike, Do you mean that if there is no specific value customized per operator, the default value should be: 4G LTE ?

Comment 11

[GoodMike]

Yes, that's what I meant. Because 4G LTE is a formal term, so I figure/suggest we can use that term in Settings.

Comment 12

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Feature work and user story bug should not have 1.4+ flag.

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

User story bug shouldn't have 1.4+ flag.

Comment 14

[Marcelino Veiga Tuimil [:sonmarce]]

According to [1] this is a 1.4 feature, so I guess we can work on it to be landed on master, right? If that is the case, as we are splitting implementation in several bugs, I suppose we should ask for 1.4? in each one. Please, can you confirm?

[1] https://wiki.mozilla.org/B2G/Roadmap#Key_Focus_1.4_Features

Comment 15

[Eric Chang [:ericcc] [:echang]]

http://mzl.la/1hrAUB8

Comment 16

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Yes, this item is 1.4 Key Focus, so we can land it. 
We actually need it faster (before Feb28) to align with QC testing schedule.
Not necessary and in fact can't set this bug to 1.4+ because it's a "feature work".
Refer to below guideline:
https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines

Comment 17

[[:fabrice] Fabrice Desré]

Carmen, do you have everything you need to make progress here?

Comment 18

[Kai-Chih Hu [:khu]]

Got update from the owner: 

Yes, Carmen is working on it to have all bugs implemented by the end of today, just waiting for code review, so if they are reviewed soon they should be landed this week.

Comment 19

[Marcelino Veiga Tuimil [:sonmarce]]

Rewritten as a user story with needed details in order to be properly tested, after being discussed with Beatriz and reviewed by Dev & QA

Comment 20

[rafael.marquez]

I will test this user story because it will be developed by Telefonica. Is there a problem? Eric, do you have tests created moztrap ?
I will send all tests when I verify the US, following the usual procedure.

Comment 21

[Carmen Jimenez Cabezas]

(In reply to Fabrice Desré [:fabrice] from comment #17)
> Carmen, do you have everything you need to make progress here?

Sorry, I answered this before but somehow the answer didn't got out.

Thanks for the offer, but I don't need help at this moment. I already uploaded a patch for the last of the three blocking bugs that solve this user story (bug 976951). It's pending of review now.

Comment 22

[Anthony Ricaud (:rik)]

Carmen: I don't see any unit test in your patches. I know Settings has low coverage so it can be annoying to start from scratch. Do you think you have the bandwidth to land those patches with unit tests included?

Comment 23

[Eric Chang [:ericcc] [:echang]]

(In reply to rafael.marquez from comment #20)
> I will test this user story because it will be developed by Telefonica. Is
> there a problem? Eric, do you have tests created moztrap ?
> I will send all tests when I verify the US, following the usual procedure.

Sure, thanks for taking this, I have some cases in the link above.

Comment 24

[Carmen Jimenez Cabezas]

(In reply to Anthony Ricaud (:rik) from comment #22)
> Carmen: I don't see any unit test in your patches. I know Settings has low
> coverage so it can be annoying to start from scratch. Do you think you have
> the bandwidth to land those patches with unit tests included?

I've updated the patch for bug976951 to add the unit test. The bug 970929 has a followup to make the unit test as soon as possible

Comment 25

[Anthony Ricaud (:rik)]

All dependencies landed so closing this bug.

Comment 26

[Eric Chang [:ericcc] [:echang]]

(In reply to rafael.marquez from comment #20)
> I will test this user story because it will be developed by Telefonica. Is
> there a problem? Eric, do you have tests created moztrap ?
> I will send all tests when I verify the US, following the usual procedure.
Here is a more complete set with dialer/message on LTE(/IPv6)
https://moztrap.mozilla.org/manage/cases/?filter-suite=570

Comment 27

[rafael.marquez]

Thanks Eric,
I will review your tests, but I will use mine because all steps are more updated and included the necessary configuration for single variant .

Comment 28

[rafael.marquez]

Verified in v1.4 branch