Closed Bug 952026 Opened 6 years ago Closed 6 years ago

[B2G] [RIL] [User story] Single Variant: Set commercial name used for a specific network mode technology

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
1.4 S2 (28feb)

People

(Reporter: skamat, Assigned: macajc)

References

Details

(Whiteboard: [ucid:LTE2, 1.4, FT:RIL][systemsfe],[dependency:Marketplace])

User Story

As an operator I should be able to change the commercial name used for a specific network mode technology (e.g. 4G or LTE for LTE technology, or H or 3.5G for HSPA technology), so that they can be adapted to each specific network or country

Acceptance criteria:
* Network mode commercial name will be configured per each MCC/MNC after inserting a new SIM card for the first time
* For example, depending on the country, LTE could be displayed as LTE, 4G, ...
* These are all the current options:
 | Network Type | Description      |
 | 4G           | 4G LTE & 4G CDMA |
 | H+           | 3.5G HSPA+       |
 | H            | 3.5G HSDPA       |
 | Ev           | 3G CDMA          |
 | 3G           | 3G UMTS          |
 | E            | EDGE             |
 | 2G           | GPRS             |
 | 1x           | 2G CDMA          |
* Network mode commercial name configuration will be applied to all existing cases:
  * Settings -> Cellular & Data: current network mode
  * Settings -> Cellular & Data -> Network operator -> Network Type: only/preferred network mode option
  * Quick Menu -> Network Type: current network mode
* There will be a default value for the case of no Network mode commercial name is configured for a MCC/MNC or no SIM card inserted
* Replacing or removing SIM card later on will imply no change in Network mode commercial name configuration
* After a factory reset, Network mode commercial name will be configured the same way as a brand new device
As I user I should be able to change the Network mode settings for various network modes(e.g. Selection of Global, LTE/CDMA, GSM/UMTS). Exact modes will be specified by operator partner)
Need change in gecko and Gecko.
Depends on: 1.4-RIL/Net/Conn
No longer depends on: 1.4-RIL/Net/Conn
Depends on: 902371, 912019
Summary: [B2G] [RIL] [User story] Network mode settings for LTE phone → [B2G] [RIL] [User story] Network mode settings for LTE/JCDMA phone
Depends on: 952043
1.4 user story supposedly needs to be complete before Sprint3.
Will communicate with team to reconfirm target milestone.
blocking-b2g: --- → backlog
Whiteboard: [ucid:LTE2, 1.4, FT:RIL]
Target Milestone: --- → 1.4 S3 (14mar)
No longer blocks: 1.4-RIL/Net/Conn
This is a 1.4+ bug.
blocking-b2g: backlog → 1.4+
Flags: in-testsuite?
Flags: in-moztrap?(echu)
Here are some questions for UX.
1. Do we need to have a signal bar for LTE?
2. What is the name of item for selection LTE network?(4G or LTE)
Flags: needinfo?(mtsai)
(In reply to Ken Chang[:ken] from comment #4)
> Here are some questions for UX.
> 2. What is the name of item for selection LTE network?(4G or LTE)
Thats a good question and different operators are using a different commercial name for this technology so there is a requirement to use the commercial name 4G or LTE accordingly to the carrier(mcc/mnc). This feature is covered by bug 923449. The requirement is to use the same name in all the device menus.
Depends on: 923449
Bug 923449 introduces a new settings (operatorResources.data.icon) that holds the operator specify value
for the text which is shown under Cellular & Data related with the data network type (2G, 3G, 4G,...).
That settings should be used in this bug also so the same value is shown at both places
The string values for the select at settings > cellular & Data > Network type will be hold on the new setting that I can add to the previously mentioned bug 923449 with the name operatorResources.data.types (If you prefer a different name just tell me and I will change it)
Depends on: 969642
Bug 969642 adds the ability to read the value from the setting (customized per operator) and changes the value shown under Cellular & Data in the Settings menu
In respond to comment 2

1. Do we need to have a signal bar for LTE? UX- Yes, we do. Just like what we have for 2G and 3G. 
2. What is the name of item for selection LTE network?(4G or LTE) UX- 4G LTE ?

And if we are going with dynamic expression, the signal bar/icon design should be just one but not two sets.
Flags: needinfo?(mtsai)
(In reply to GoodMike from comment #9)
> In respond to comment 2
> 2. What is the name of item for selection LTE network?(4G or LTE) UX- 4G LTE
> ?
> 
I want to avoid any confusion as this is a carrier requirement.
GoodMike, Do you mean that if there is no specific value customized per operator, the default value should be: 4G LTE ?
Flags: needinfo?(mtsai)
Yes, that's what I meant. Because 4G LTE is a formal term, so I figure/suggest we can use that term in Settings.
Flags: needinfo?(mtsai)
Depends on: 970929
Blocks: 960372
Feature work and user story bug should not have 1.4+ flag.
blocking-b2g: 1.4+ → backlog
No longer depends on: 902371
Depends on: 973771
Flags: in-moztrap?(echu) → in-moztrap?(echang)
Assignee: nobody → cjc
Whiteboard: [ucid:LTE2, 1.4, FT:RIL] → [ucid:LTE2, 1.4, FT:RIL][systemsfe]
Target Milestone: 1.4 S3 (14mar) → 1.4 S2 (28feb)
blocking-b2g: backlog → 1.4+
Depends on: 975703
User story bug shouldn't have 1.4+ flag.
blocking-b2g: 1.4+ → ---
According to [1] this is a 1.4 feature, so I guess we can work on it to be landed on master, right? If that is the case, as we are splitting implementation in several bugs, I suppose we should ask for 1.4? in each one. Please, can you confirm?

[1] https://wiki.mozilla.org/B2G/Roadmap#Key_Focus_1.4_Features
Flags: needinfo?(whuang)
Flags: in-moztrap?(echang) → in-moztrap+
QA Contact: echang
Yes, this item is 1.4 Key Focus, so we can land it. 
We actually need it faster (before Feb28) to align with QC testing schedule.
Not necessary and in fact can't set this bug to 1.4+ because it's a "feature work".
Refer to below guideline:
https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines
Flags: needinfo?(whuang)
No longer blocks: b2g--telephony-1.4
Blocks: 976427
Carmen, do you have everything you need to make progress here?
Flags: needinfo?(cjc)
Depends on: 976951
Got update from the owner: 

Yes, Carmen is working on it to have all bugs implemented by the end of today, just waiting for code review, so if they are reviewed soon they should be landed this week.
Rewritten as a user story with needed details in order to be properly tested, after being discussed with Beatriz and reviewed by Dev & QA
User Story: (updated)
Summary: [B2G] [RIL] [User story] Network mode settings for LTE/JCDMA phone → [B2G] [RIL] [User story] Single Variant: Set commercial name used for a specific network mode techonology
Summary: [B2G] [RIL] [User story] Single Variant: Set commercial name used for a specific network mode techonology → [B2G] [RIL] [User story] Single Variant: Set commercial name used for a specific network mode technology
I will test this user story because it will be developed by Telefonica. Is there a problem? Eric, do you have tests created moztrap ?
I will send all tests when I verify the US, following the usual procedure.
QA Contact: echang → rafael.marquez
(In reply to Fabrice Desré [:fabrice] from comment #17)
> Carmen, do you have everything you need to make progress here?

Sorry, I answered this before but somehow the answer didn't got out.

Thanks for the offer, but I don't need help at this moment. I already uploaded a patch for the last of the three blocking bugs that solve this user story (bug 976951). It's pending of review now.
Flags: needinfo?(cjc)
Carmen: I don't see any unit test in your patches. I know Settings has low coverage so it can be annoying to start from scratch. Do you think you have the bandwidth to land those patches with unit tests included?
Flags: needinfo?(cjc)
(In reply to rafael.marquez from comment #20)
> I will test this user story because it will be developed by Telefonica. Is
> there a problem? Eric, do you have tests created moztrap ?
> I will send all tests when I verify the US, following the usual procedure.

Sure, thanks for taking this, I have some cases in the link above.
(In reply to Anthony Ricaud (:rik) from comment #22)
> Carmen: I don't see any unit test in your patches. I know Settings has low
> coverage so it can be annoying to start from scratch. Do you think you have
> the bandwidth to land those patches with unit tests included?

I've updated the patch for bug976951 to add the unit test. The bug 970929 has a followup to make the unit test as soon as possible
Flags: needinfo?(cjc)
All dependencies landed so closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
(In reply to rafael.marquez from comment #20)
> I will test this user story because it will be developed by Telefonica. Is
> there a problem? Eric, do you have tests created moztrap ?
> I will send all tests when I verify the US, following the usual procedure.
Here is a more complete set with dialer/message on LTE(/IPv6)
https://moztrap.mozilla.org/manage/cases/?filter-suite=570
Thanks Eric,
I will review your tests, but I will use mine because all steps are more updated and included the necessary configuration for single variant .
Depends on: 975265
Verified in v1.4 branch
Status: RESOLVED → VERIFIED
Whiteboard: [ucid:LTE2, 1.4, FT:RIL][systemsfe] → [ucid:LTE2, 1.4, FT:RIL][systemsfe],[dependency:Marketplace]
You need to log in before you can comment on or make changes to this bug.