97563 - HANG while printing a page with a plugin

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Peter Lubczynski]

See Bugscape bug: http://bugscape.netscape.com/show_bug.cgi?id=8554

So far, I've found these sites cause Mozilla (oddly not MFCEmbed or viewer???)
and the product mentioned in the bugscape bug to hang while printing:

http://www.disney.com
http://www.macromedia.com
http://www.emailtrack.com

I'm sure there are MANY others, too.
If someone could attach a simplified HTML testcase, that would be greatly be
appreciated.

I think this may be a layout problem. In a debug build, I get an endless loop of
ASSERTIONs in nsBlockFrame.cpp, "redo line on totally empty line:
'aState.IsImpactedByFloater()'"

Comment 1

[Peter Lubczynski]

adding topembed keyword per Marek's request.

Comment 2

[Peter Lubczynski]

Karnaze, I think this is your bug and I have a TESTCASE for you!

If you have a plugin inside a table, we ASSERT forever in debug mode and hang in
release while printing. The simple markup that causes this is:

<table width="300"  border="1">
  <tr> 
    <td><embed
src="http://www.macromedia.com/shockwave/download/triggerpages/flash.swf" 
	     type="application/x-shockwave-flash" width=300 height=120>
        </embed> 
      </td>
  </tr>
</table>

Comment 3

[Peter Lubczynski]

Attachment: simple testcase 1x1 table with an EMBED

Comment 4

[karnaze (gone)]

waterson, I'm seeing the assertions in the block code as well, but only in 
mozilla. Changing the milestone to m0.9.5, since it is unlikely to get fixed in 
time for m0.9.4.

Comment 5

[Peter Lubczynski]

I have a fix, back over to me. We weren't setting the reflow status to
NS_FRAME_COMPLETE only in the printing case. Patch on its way.

Comment 6

[Peter Lubczynski]

Attachment: patch to set reflow status when printing

Comment 7

[av (gone)]

Comment on attachment 48240 [details] [diff] [review]
patch to set reflow status when printing

r=av

Comment 8

[Marc Attinasi]

Comment on attachment 48240 [details] [diff] [review]
patch to set reflow status when printing

cool Peter! sr=attinasi

Comment 9

[Peter Lubczynski]

Checked into the trunk and mozilla0.9.2 branch as I think if I understand
correctly, at this time I don't need approvals because the trunk is open and
this is marked topembed.

However, I think I still need approval for the the mozilla0.9.4 trunk so I'm
leaving this open.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 48240 [details] [diff] [review]
patch to set reflow status when printing

a=asa for checkin to Mozilla 0.9.4 branch

Comment 11

[Peter Lubczynski]

Thanks! Checked into mozilla0.9.4 branch, marking FIXED.

Comment 12

[sujay]

Okay I installed the 9/5 trunk build on windows.

now we don't hang..

however, I get blank pages when I print out the emailtrack.com
and macromedia websites...this is expected behavior?

for the disney.com website the middle of the page comes out
blank. but the top and bottom content print out fine.

Comment 13

[sujay]

okay the issue with plugins not printing is bug 27478.

Thus, this bug can be closed because we don't hang anymore
when printing a page with plugins.

verified in 9/5 trunk build.

Comment 14

[Keyser Sose]

*** Bug 97154 has been marked as a duplicate of this bug. ***