975937 - crash in mozilla::layers::ShaderProgramOGL::Activate()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-4a5f1f08-2573-4096-ab8f-339172140219.
=============================================================

This appears in the Android logcat right before the crash,

> === SHADER COMPILATION FAILED ===
> === Source:
> #ifdef GL_ES
> precision mediump float;
> #define COLOR_PRECISION lowp
> #else
> #define COLOR_PRECISION
> #endif
> varying vec2 vTexCoord;
> #extension GL_OES_EGL_image_external : require
> uniform samplerExternalOES uTexture;
> vec4 sample(vec2 coord) {
>   vec4 color;
>   color = texture2D(uTexture, coord);
>   return color;
> }
> void main() {
>   vec4 color = sample(vTexCoord);
>   COLOR_PRECISION float mask = 1.0;
>   color *= mask;
>   gl_FragColor = color;
> }
> 
> 
> === Log:
> 0:8: P0007: Extension directive must occur before any non-preprocessor tokens
> 0:9: L0001: Typename expected, found 'samplerExternalOES'
> ============

The crashes started with the 2014-02-19 nightly and are probably caused by bug 926128, considering that bug touched the shader program and was landed on 2014-02-18.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: shader_complie_failed

I saw similar issue resolve in bug 783754. According that bug, we should move all #entension macro to the top of shader code. I made a simple patch to move the #entension location. But I don't have any device that causes this issue. So I cannot confirm this patch fix this problem now.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8380456 [details] [diff] [review]
shader_complie_failed

Thanks for the patch! Seeing this is a top crash on Fennec and we don't have STR, let's take this speculative fix and look at the crash data afterwards.

Comment 3

[Andreas Gal :gal]

Comment on attachment 8380456 [details] [diff] [review]
shader_complie_failed

This will definitely fix the problem. Thanks for the quick work here Morris.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try push: https://tbpl.mozilla.org/?tree=Try&rev=ffa129617c7b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b60344ed5f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6b60344ed5f