975991 - Extensions without icon get displayed with the icon of the previous extension viewed if extension does not come from AMO

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Add-on Manager, defect, P5)

Description

[Rika Pi]

Attachment: Screenshot_2014-02-23-13-33-00.png

Fennec 28.0b4
OS: Android 4.2.2

Addons not from AMO still have this problem if addon has no icon.

ex:
to Replicate bug:

download an addon from outside AMO that does not have an icon 
(ex: http://mozilla.github.io/shumway/extension/firefox/shumway.xpi)
after downloading and installing go to addons page
tap on an addon with an icon
go out of detail view
tap the addon that has no icon and does not come from AMO

Expected result:
for no icon to show when addon has no icon

Actual result:
icon of last addon view with an icon is shown

Comment 1

[Aaron Train [:aaronmt]]

Thanks for filing. This is reproducible.

There also seems to be an issue as well where add-on icons are not displayed (e.g, Cloud Viewer) doesn't work but Phony does display their associated icon. Not sure if that's at fault of the XPI or an issue with the manager.

Comment 2

[Aaron Train [:aaronmt]]

Attachment: screenshot (Aurora 29.0)

We should show a default puzzle icon or something. Cloud Viewer is a broken document, Shumway show's the default missing picture icon from Gecko.

Comment 3

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Created attachment 8380646 [details]
> screenshot (Aurora 29.0)
> 
> We should show a default puzzle icon or something. Cloud Viewer is a broken
> document, Shumway show's the default missing picture icon from Gecko.

Filed bug 991705

Comment 4

[:Margaret Leibovic]

This should be fixed by the patch in bug 991705. We can verify when that patch lands.

Comment 5

[:Margaret Leibovic]

I can confirm this was fixed by the patch in bug 991705.

Comment 6

[Cristina Madaras, QA [:CristinaM]]

I can reproduce this on both Nightly (2014-05-08) and Aurora (2014-05-08).
Device: Galaxy Nexus (Android 4.2.1)

Comment 7

[:Margaret Leibovic]

(In reply to cristina.madaras from comment #6)
> I can reproduce this on both Nightly (2014-05-08) and Aurora (2014-05-08).
> Device: Galaxy Nexus (Android 4.2.1)

Can you elaborate on what you're seeing? I just tried to reproduce on Nightly and didn't see this issue.

Comment 8

[Cristina Madaras, QA [:CristinaM]]

I installed Phony and Shumway add-ons.
Tap on Shumway add-on - default icon is displayed.
Close Shumway and tap on Phony - Phony icon is displayed
Close Phony and tap again on Shumway - Phony icon is displayed.
 
Please see the video.

https://www.youtube.com/watch?v=cY4a68gLu-U&feature=youtu.be

Comment 9

[:Margaret Leibovic]

I'll just reopen this bug, since it looks like the patch for bug 991705 didn't fix this after all.

Looking at the video (and testing locally), it looks like there's also another problem similar to bug 991705, where we show a broken icon if we have problems loading the add-on icon over the network.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 11

[Mike Taylor [:miketaylr]]

Seems like a good bug to familiarize myself with some of the addons manager code.

Comment 12

[Mike Taylor [:miketaylr]]

Gonna close this as WFM, I can't get it to reproduce. Here's an attempt to reproduce Comment #8: 

https://www.youtube.com/watch?v=cdwZ-HgnWLg

Cristina, would you mind trying to verify? Thanks!