991705 - Missing default add-on icon in about:addons for no bundled icons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

Install: https://addons.mozilla.org/en-US/android/addon/home-page-feeds/

Visit about:addons, see missing icon.

--
Nightly/Aurora (04/03)

Comment 1

[Aaron Train [:aaronmt]]

So there's no bundled icon with https://addons.mozilla.org/android/downloads/file/252490/home_page_feeds-0.1-an-android.xpi but we shouldn't be showing a broken document icon.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Device: LG Nexus 4
OS: Android 4.4.2
Builds: 
1.Nightly 29.0a1 (2014-02-03)- The message appears "Home Page Feeds could not be installed because it is not compatible with Nightly 29.0a1"
2.Nightly 30.0a1 (2014-02-04)- affected, there is no icon

Comment 3

[Aaron Train [:aaronmt]]

This should be reproducible with add-ons with wider version compatibility range.

Comment 4

[:Margaret Leibovic]

I can confirm this is even an issue on release, so I don't know that it's a regression.

Comment 5

[:Margaret Leibovic]

Attachment: Default to puzzle icon if an add-on doesn't have an icon

This just copies the desktop behavior of including a puzzle icon if the add-on doesn't have an icon.

Currently in the detail view, we just hide the icon altogether, which seems broken. This logic traces back to bug 696532, so I think this is just a bug we never found or fixed.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8403013 [details] [diff] [review]
Default to puzzle icon if an add-on doesn't have an icon

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not a regression, but we want to feature add-ons more heavily in the fx30 release
User impact if declined: add-on icons look broken in about:addons if the add-on doesn't bundle an icon
Testing completed (on m-c, etc.): just landed on fx-team
Risk to taking this patch (and alternatives if risky): low-risk, changes icon setting logic in about:addons
String or IDL/UUID changes made by this patch: none

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/d54f7e4f84c1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d54f7e4f84c1

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8403013 [details] [diff] [review]
Default to puzzle icon if an add-on doesn't have an icon

low risk *and* provides a nicer experience for a user?  great! uplift!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b61e5fae72d4

Comment 11

[Teodora Vermesan (:TeoVermesan)]

The default puzzle icon appears if an add-on(tested with: home feeds& world cup) doesn't have an icon.
Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 31.0a1 (2014-04-17) and Firefox for Android 30.0a2 (2014-04-17)