Closed
Bug 976152
Opened 10 years ago
Closed 10 years ago
Move test-agent off of npm
Categories
(Firefox OS Graveyard :: Gaia::TestAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S2 (28feb)
People
(Reporter: gaye, Assigned: gaye)
References
Details
(Whiteboard: [p=3])
Attachments
(2 files)
:kgrandon did some excellent work to fetch our package.json dependencies in gaia off of npm. We are still somewhat dependent on npm in random places (ie test-agent) which is still hurting us (for example https://travis-ci.org/mozilla-b2g/gaia/jobs/19500054).
Comment 1•10 years ago
|
||
Should the test-agent modules simply be bundled into the current dependency list? Current dependencies are: "test-agent": "0.18.0", "marionette-client": "0.5.4", "b2g-scripts": "0.3.0", "chai": "0.5.3", "mocha": "~1.7", "xpcwindow": "0.4.4"
Comment 2•10 years ago
|
||
FTR- we only need these "test-agent": "0.18.0", "chai": "0.5.3", "mocha": "~1.7" (and mocha/chai could be omitted they are checked into the tree for browser usage anyway)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gaye
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8380787 -
Flags: review?(kgrandon)
Assignee | ||
Updated•10 years ago
|
Attachment #8380787 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 4•10 years ago
|
||
:lightsofapollo gave me a shrug+ since :kgrandon mia
Comment 5•10 years ago
|
||
Cc Yuren and Ricky so that they know what happens here. As long as Travis is happy with this change, then it should work. But it's not easy to check with the new gaia-node-modules.
Updated•10 years ago
|
Flags: needinfo?(yurenju.mozilla)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8381623 -
Flags: review?(jlal)
Assignee | ||
Comment 7•10 years ago
|
||
Ok well travis is good and I :lightsofapollo was onboard for this change, so I'll merge.
Assignee | ||
Updated•10 years ago
|
Attachment #8381623 -
Flags: review?(jlal) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/0477d1e32cfac32167aedcf9dbc078df30b5669a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Flags: needinfo?(yurenju.mozilla)
Comment 9•10 years ago
|
||
gaia-node-modules master: 3ea87743d2c3a285e023bca6f7441bd7bc66aa32
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=3]
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•