Closed Bug 976152 Opened 7 years ago Closed 7 years ago

Move test-agent off of npm

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: gaye, Assigned: gaye)

References

Details

(Whiteboard: [p=3])

Attachments

(2 files)

:kgrandon did some excellent work to fetch our package.json dependencies in gaia off of npm. We are still somewhat dependent on npm in random places (ie test-agent) which is still hurting us (for example https://travis-ci.org/mozilla-b2g/gaia/jobs/19500054).
Should the test-agent modules simply be bundled into the current dependency list? Current dependencies are: 

"test-agent": "0.18.0",
"marionette-client": "0.5.4",
"b2g-scripts": "0.3.0",
"chai": "0.5.3",
"mocha": "~1.7",
"xpcwindow": "0.4.4"
FTR- we only need these

"test-agent": "0.18.0",
"chai": "0.5.3",
"mocha": "~1.7"

(and mocha/chai could be omitted they are checked into the tree for browser usage anyway)
Assignee: nobody → gaye
Attachment #8380787 - Flags: review?(kgrandon) → review+
:lightsofapollo gave me a shrug+ since :kgrandon mia
Cc Yuren and Ricky so that they know what happens here.

As long as Travis is happy with this change, then it should work. But it's not easy to check with the new gaia-node-modules.
Flags: needinfo?(yurenju.mozilla)
Ok well travis is good and I :lightsofapollo was onboard for this change, so I'll merge.
Attachment #8381623 - Flags: review?(jlal) → review+
https://github.com/mozilla-b2g/gaia/commit/0477d1e32cfac32167aedcf9dbc078df30b5669a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(yurenju.mozilla)
gaia-node-modules master: 3ea87743d2c3a285e023bca6f7441bd7bc66aa32
Whiteboard: [p=3]
Target Milestone: --- → 1.4 S2 (28feb)
Depends on: 998759
You need to log in before you can comment on or make changes to this bug.