976271 - [AccessFu] Add tests for dialog support

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

We should add tests for the support we added in bug 964534.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Add dialog tests to jsat suite.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8380882 [details] [diff] [review]
Add dialog tests to jsat suite.

Review of attachment 8380882 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! r=me with a couple nits.

::: accessible/tests/mochitest/jsat/jsatcommon.js
@@ +226,5 @@
>                                       this.currentPair[0].json);
>        }
> +
> +      if (!this.currentPair[1]) {
> +	this.pump();

nit: indentation.

::: accessible/tests/mochitest/jsat/test_content_integration.html
@@ +145,5 @@
> +
> +            // Open dialog in outer doc, while cursor is also in outer doc
> +            [simpleMoveNext,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },

just doc.defaultView.showAlert

@@ +146,5 @@
> +            // Open dialog in outer doc, while cursor is also in outer doc
> +            [simpleMoveNext,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],

nit: indentation.

@@ +148,5 @@
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },

just doc.defaultView.hideAlert

@@ +149,5 @@
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },
> +	     null ], // XXX: Place cursor back where it was.

nit: indentation.

@@ +156,5 @@
> +            [simpleMoveFirst,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [simpleMoveNext,
> +             { speak: 'wow heading level 1 such app' }],
> +            [function () {

just doc.defaultView.showAlert

@@ +160,5 @@
> +            [function () {
> +               doc.defaultView.showAlert()
> +             }, { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },

just doc.defaultView.hideAlert

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/018f3ba65be2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/018f3ba65be2