Closed Bug 976271 Opened 9 years ago Closed 9 years ago

[AccessFu] Add tests for dialog support

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

We should add tests for the support we added in bug 964534.
Attachment #8380882 - Flags: review?(yzenevich)
Comment on attachment 8380882 [details] [diff] [review]
Add dialog tests to jsat suite.

Review of attachment 8380882 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! r=me with a couple nits.

::: accessible/tests/mochitest/jsat/jsatcommon.js
@@ +226,5 @@
>                                       this.currentPair[0].json);
>        }
> +
> +      if (!this.currentPair[1]) {
> +	this.pump();

nit: indentation.

::: accessible/tests/mochitest/jsat/test_content_integration.html
@@ +145,5 @@
> +
> +            // Open dialog in outer doc, while cursor is also in outer doc
> +            [simpleMoveNext,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },

just doc.defaultView.showAlert

@@ +146,5 @@
> +            // Open dialog in outer doc, while cursor is also in outer doc
> +            [simpleMoveNext,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],

nit: indentation.

@@ +148,5 @@
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },

just doc.defaultView.hideAlert

@@ +149,5 @@
> +            [function () { doc.defaultView.showAlert() },
> +	     { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },
> +	     null ], // XXX: Place cursor back where it was.

nit: indentation.

@@ +156,5 @@
> +            [simpleMoveFirst,
> +            { speak: 'Phone status bar Traversal Rule test document' }],
> +            [simpleMoveNext,
> +             { speak: 'wow heading level 1 such app' }],
> +            [function () {

just doc.defaultView.showAlert

@@ +160,5 @@
> +            [function () {
> +               doc.defaultView.showAlert()
> +             }, { speak: 'This is an alert! heading level 1 dialog' }],
> +
> +            [function () { doc.defaultView.hideAlert() },

just doc.defaultView.hideAlert
Attachment #8380882 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/018f3ba65be2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.