Closed Bug 976285 Opened 8 years ago Closed 8 years ago

/rules/:id endpoint needs to return data_version/csrf token

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file, 1 obsolete file)

a patch that actually works
3.04 KB, patch
nthomas
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review 
The Balrog submitter code depends on being able to get data version and a csrf token through a HEAD request. Currently, this only gets returned for releases, not rules, which means we can't update rules to eg, change a mapping.
Attached patch send back headers (obsolete) — — Splinter Review
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8382238 - Flags: review?(nthomas)
Comment on attachment 8382238 [details] [diff] [review]
send back headers

Huh. Test passes, but is failing when Balrog submitter is making HEAD requests...
Attachment #8382238 - Attachment is obsolete: true
Attachment #8382238 - Flags: review?(nthomas)
Attachment #8383160 - Flags: review?(nthomas)
Attachment #8383160 - Flags: review?(nthomas) → review+
Comment on attachment 8383160 [details] [diff] [review]
a patch that actually works

Pushed. Will wait for a few patches before asking for a push.
Attachment #8383160 - Flags: checked-in+
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/622f35b77eb10330000c1a44a9ad31533204a78d
bug 976285: /rules/:id endpoint needs to return data_version/csrf token. r=nthomas
Depends on: 983135
In production now, and I used it to delete a rule that we temporarily added for bug 947965.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
(In reply to Ben Hearsum [:bhearsum] from comment #6)
> In production now, and I used it to delete a rule that we temporarily added
> for bug 947965.

Whoops, this was meant for bug 938132.

I did confirm that this endpoint now returns X-Data-Version and X-CSRF-Token, though.
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.