976285 - /rules/:id endpoint needs to return data_version/csrf token

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

The Balrog submitter code depends on being able to get data version and a csrf token through a HEAD request. Currently, this only gets returned for releases, not rules, which means we can't update rules to eg, change a mapping.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: send back headers

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8382238 [details] [diff] [review]
send back headers

Huh. Test passes, but is failing when Balrog submitter is making HEAD requests...

Comment 3

[[e-mail] (:bhearsum)]

Attachment: a patch that actually works

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8383160 [details] [diff] [review]
a patch that actually works

Pushed. Will wait for a few patches before asking for a push.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/622f35b77eb10330000c1a44a9ad31533204a78d
bug 976285: /rules/:id endpoint needs to return data_version/csrf token. r=nthomas

Comment 6

[[e-mail] (:bhearsum)]

In production now, and I used it to delete a rule that we temporarily added for bug 947965.

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #6)
> In production now, and I used it to delete a rule that we temporarily added
> for bug 947965.

Whoops, this was meant for bug 938132.

I did confirm that this endpoint now returns X-Data-Version and X-CSRF-Token, though.