Settings Regions That are TranslateX out of view take up an extra layer

RESOLVED FIXED in 1.4 S2 (28feb)

Status

defect
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

({perf})

unspecified
1.4 S2 (28feb)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c=handeye p=3 s= u=1.4])

Attachments

(3 attachments, 3 obsolete attachments)

Posted file Layer Tree
See the attached layer. We're using up extra memory and an extra layer because of the sections that are non visible. Optimize this out.
Saw that we take an extra layer from the sections listed above in the settings app. Just changing the visibility retains the extra layer. Sometimes gecko optimizes it out, but not all the time. The downside to this patch is that every time we switch a section, we incur a ~8ms reflow on a hamachi. Currently, we only incur this reflow on the first time we go into a sub section. Is this tradeoff ok? Otherwise, do we have to extract all the subpages out to an extra page?
Attachment #8380932 - Flags: review?(bgirard)
Attachment #8380932 - Flags: review?(21)
Posted file Layer Tree w/ Patch (obsolete) —
And a profile:

https://people.mozilla.org/~bgirard/cleopatra/#report=9d77c8ca60e11387983095932baf3381aed04115

We still have > 100 ms rasterizes, but not quite as often.
Assignee

Updated

5 years ago
Hardware: x86 → ARM
Target Milestone: --- → 1.4 S2 (28feb)
Comment on attachment 8380932 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16583

The issue with such a patch is that it basically destroyed all transitions between panels.
Attachment #8380932 - Flags: review?(21) → review-
I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be triggering a reflow, and it works very well with css transitions. Although, it may keep a layer around, I am not sure.
(In reply to Eitan Isaacson [:eeejay] from comment #5)
> I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be
> triggering a reflow, and it works very well with css transitions. Although,
> it may keep a layer around, I am not sure.

It keeps a layer around.
Posted file Layer Tree w/ Patch
Attachment #8380933 - Attachment is obsolete: true
Attachment #8380932 - Attachment is obsolete: true
Works while keeping the animations. Can you please check to see if there is some other edge case? Thanks
Attachment #8383434 - Attachment is obsolete: true
Attachment #8384214 - Flags: review?(21)
Landed in master - 6a566e8ad2b94b8123da1a43a6ee870612b11759
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.