Created attachment 8380929 [details] Layer Tree See the attached layer. We're using up extra memory and an extra layer because of the sections that are non visible. Optimize this out.
Created attachment 8380932 [details] [review] https://github.com/mozilla-b2g/gaia/pull/16583 Saw that we take an extra layer from the sections listed above in the settings app. Just changing the visibility retains the extra layer. Sometimes gecko optimizes it out, but not all the time. The downside to this patch is that every time we switch a section, we incur a ~8ms reflow on a hamachi. Currently, we only incur this reflow on the first time we go into a sub section. Is this tradeoff ok? Otherwise, do we have to extract all the subpages out to an extra page?
Created attachment 8380933 [details] Layer Tree w/ Patch And a profile: https://people.mozilla.org/~bgirard/cleopatra/#report=9d77c8ca60e11387983095932baf3381aed04115 We still have > 100 ms rasterizes, but not quite as often.
Hardware: x86 → ARM
Target Milestone: --- → 1.4 S2 (28feb)
Comment on attachment 8380932 [details] [review] https://github.com/mozilla-b2g/gaia/pull/16583 The issue with such a patch is that it basically destroyed all transitions between panels.
Attachment #8380932 - Flags: review?(21) → review-
Comment on attachment 8380932 [details] [review] https://github.com/mozilla-b2g/gaia/pull/16583 Thanks, reworking.
I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be triggering a reflow, and it works very well with css transitions. Although, it may keep a layer around, I am not sure.
(In reply to Eitan Isaacson [:eeejay] from comment #5) > I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be > triggering a reflow, and it works very well with css transitions. Although, > it may keep a layer around, I am not sure. It keeps a layer around.
Created attachment 8383432 [details] Layer Tree w/ Patch
Attachment #8380933 - Attachment is obsolete: true
Attachment #8380932 - Attachment is obsolete: true
Created attachment 8384214 [details] [review] https://github.com/mozilla-b2g/gaia/pull/16764 Works while keeping the animations. Can you please check to see if there is some other edge case? Thanks
Comment on attachment 8384214 [details] [review] https://github.com/mozilla-b2g/gaia/pull/16764 LGTM when trying it :)
Attachment #8384214 - Flags: review?(21) → review+
Landed in master - 6a566e8ad2b94b8123da1a43a6ee870612b11759
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.