Closed Bug 976392 Opened 7 years ago Closed 7 years ago
Move moz2d to libxul
No description provided.
George, FWIW I didn't need to export any new skia symbols, all I had to do was to get rid of SKIA_IMPLEMENTATION and GR_IMPLEMENTATION in gfx/2d since that code is now built against the external skia interface.
PGO run on try just to sanity check the linker memory usage + get test results: https://tbpl.mozilla.org/?tree=Try&rev=9cb1044ab739
Ok, awesome! So we're still defining SKIA/GR_IMPLEMENTATION in gfx/skia itself, but not elsewhere? That sounds correct to me.
(In reply to George Wright (:gw280) from comment #4) > Ok, awesome! So we're still defining SKIA/GR_IMPLEMENTATION in gfx/skia > itself, but not elsewhere? That sounds correct to me. Yep.
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailapocalypse) from comment #3) > PGO run on try just to sanity check the linker memory usage + get test > results: https://tbpl.mozilla.org/?tree=Try&rev=9cb1044ab739 Er, this didn't end up becoming a PGO build... Let's try again.
Linker vmem size on a recent inbound PGO build: 2786115584 Linker vmem size on this try build: 2839953408 We should be good to go here.
Attachment #8381064 - Flags: review?(jmuizelaar) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Confirmed that backing out the patch from bug 976392 results in a successful compilation.
You need to log in before you can comment on or make changes to this bug.