Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla30
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → ehsan
Blocks: 935778
Attachment #8381064 - Flags: review?(jmuizelaar)
George, FWIW I didn't need to export any new skia symbols, all I had to do was to get rid of SKIA_IMPLEMENTATION and GR_IMPLEMENTATION in gfx/2d since that code is now built against the external skia interface.
PGO run on try just to sanity check the linker memory usage + get test results: https://tbpl.mozilla.org/?tree=Try&rev=9cb1044ab739
Ok, awesome! So we're still defining SKIA/GR_IMPLEMENTATION in gfx/skia itself, but not elsewhere? That sounds correct to me.
(In reply to George Wright (:gw280) from comment #4)
> Ok, awesome! So we're still defining SKIA/GR_IMPLEMENTATION in gfx/skia
> itself, but not elsewhere? That sounds correct to me.

Yep.
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailapocalypse) from comment #3)
> PGO run on try just to sanity check the linker memory usage + get test
> results: https://tbpl.mozilla.org/?tree=Try&rev=9cb1044ab739

Er, this didn't end up becoming a PGO build...  Let's try again.
Linker vmem size on a recent inbound PGO build:  2786115584
Linker vmem size on this try build:  2839953408

We should be good to go here.
Attachment #8381064 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/852fa926deae
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 977279
Depends on: 977701
Confirmed that backing out the patch from bug 976392 results in a successful compilation.
No longer depends on: 977279
Depends on: 978776
You need to log in before you can comment on or make changes to this bug.